This repository was archived by the owner on Mar 22, 2023. It is now read-only.
[stable-1.8] Ubsan fixes#1114
Merged
lukaszstolarczuk merged 2 commits intopmem:stable-1.8from Jul 1, 2021
Merged
Conversation
On tests listed bellow the reserve method is being called before any allocation on the object therefore realloc being called without any previous allocation. Inside realloc _data is being used with the operator '[]', as it is nullptr at that moment it's an undefined behaviour. This patch simply returns a call to alloc if _data is nullptr. This tests fails on PowerPC with Segmentation Fault because of this issue: segment_vector_array_expsize_assign_exceptions_oom_0_none segment_vector_array_expsize_assign_exceptions_oom_0_memcheck segment_vector_array_expsize_capacity_exceptions_oom_0_none segment_vector_array_expsize_capacity_exceptions_oom_0_memcheck segment_vector_array_expsize_modifiers_exceptions_oom_0_none segment_vector_array_expsize_modifiers_exceptions_oom_0_memcheck segment_vector_vector_expsize_assign_exceptions_oom_0_none segment_vector_vector_expsize_assign_exceptions_oom_0_memcheck segment_vector_vector_expsize_capacity_exceptions_oom_0_none segment_vector_vector_expsize_capacity_exceptions_oom_0_memcheck segment_vector_vector_expsize_modifiers_exceptions_oom_0_none segment_vector_vector_expsize_modifiers_exceptions_oom_0_memcheck segment_vector_vector_fixedsize_assign_exceptions_oom_0_none segment_vector_vector_fixedsize_assign_exceptions_oom_0_memcheck Signed-off-by: Lucas A. M. Magalhães lamm@linux.ibm.com
Member
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @igchor)
Codecov Report
@@ Coverage Diff @@
## stable-1.8 #1114 +/- ##
==============================================
- Coverage 92.18% 92.16% -0.02%
==============================================
Files 34 34
Lines 3658 3665 +7
==============================================
+ Hits 3372 3378 +6
- Misses 286 287 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This fixes following tests under UBSAN: vector_modifiers_type_requirements_0_none vector_parameters_0_none They failed with following error message: "runtime error: reference binding to null pointer of type" This fix is continuation of 41ddc88
karczex
reviewed
Jul 1, 2021
karczex
left a comment
karczex
left a comment
There was a problem hiding this comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is