mpsc_queue: do not call ringbuf_consume/release with number of byte#1121
mpsc_queue: do not call ringbuf_consume/release with number of byte#1121lukaszstolarczuk merged 2 commits intopmem:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 94.21% 94.29% +0.07%
==========================================
Files 52 52
Lines 5325 5343 +18
==========================================
+ Hits 5017 5038 +21
+ Misses 308 305 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6a13ec5 to
c722f09
Compare
karczex
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)
include/libpmemobj++/detail/ringbuf.hpp, line 121 at r2 (raw file):
{ if (length >= RBUF_OFF_MASK) throw std::out_of_range("ringbuf length too big");
we could add test for that
KFilipek
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)
but rather with number of cachelines. This allows to workaround the size limitation.
c722f09 to
217c0db
Compare
igchor
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
include/libpmemobj++/detail/ringbuf.hpp, line 121 at r2 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
we could add test for that
Done.
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @igchor)
This change is