Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

mpsc_queue: do not call ringbuf_consume/release with number of byte#1121

Merged
lukaszstolarczuk merged 2 commits intopmem:masterfrom
igchor:queue_size_cacheline
Jul 5, 2021
Merged

mpsc_queue: do not call ringbuf_consume/release with number of byte#1121
lukaszstolarczuk merged 2 commits intopmem:masterfrom
igchor:queue_size_cacheline

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Jul 2, 2021

This change is Reviewable

@igchor igchor mentioned this pull request Jul 2, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2021

Codecov Report

Merging #1121 (217c0db) into master (2a8e855) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1121      +/-   ##
==========================================
+ Coverage   94.21%   94.29%   +0.07%     
==========================================
  Files          52       52              
  Lines        5325     5343      +18     
==========================================
+ Hits         5017     5038      +21     
+ Misses        308      305       -3     
Flag Coverage Δ
tests_clang_debug_cpp17 93.89% <100.00%> (+0.19%) ⬆️
tests_gcc_debug 91.00% <84.78%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/detail/ringbuf.hpp 97.08% <100.00%> (+0.04%) ⬆️
include/libpmemobj++/experimental/mpsc_queue.hpp 94.82% <100.00%> (+0.38%) ⬆️
include/libpmemobj++/experimental/radix_tree.hpp 98.29% <0.00%> (ø)
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.20% <0.00%> (+0.15%) ⬆️
include/libpmemobj++/container/vector.hpp 92.95% <0.00%> (+0.33%) ⬆️
include/libpmemobj++/transaction.hpp 80.64% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8e855...217c0db. Read the comment docs.

@igchor igchor force-pushed the queue_size_cacheline branch from 6a13ec5 to c722f09 Compare July 2, 2021 16:23
Copy link
Copy Markdown

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)


include/libpmemobj++/detail/ringbuf.hpp, line 121 at r2 (raw file):

	{
		if (length >= RBUF_OFF_MASK)
			throw std::out_of_range("ringbuf length too big");

we could add test for that

Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)

igchor added 2 commits July 5, 2021 16:33
but rather with number of cachelines. This allows to workaround
the size limitation.
@igchor igchor force-pushed the queue_size_cacheline branch from c722f09 to 217c0db Compare July 5, 2021 14:33
Copy link
Copy Markdown
Contributor Author

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)


include/libpmemobj++/detail/ringbuf.hpp, line 121 at r2 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

we could add test for that

Done.

Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igchor)

@lukaszstolarczuk lukaszstolarczuk merged commit 9d4af67 into pmem:master Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants