Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

radix_tree: fix pmemcheck annotation#1123

Merged
lukaszstolarczuk merged 1 commit intopmem:masterfrom
igchor:radix_fix_annotation
Jul 5, 2021
Merged

radix_tree: fix pmemcheck annotation#1123
lukaszstolarczuk merged 1 commit intopmem:masterfrom
igchor:radix_fix_annotation

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Jul 2, 2021

Use annotation only if PMEMCHECK is enabled (not just any valgrind tool).


This change is Reviewable

Use annotation only if PMEMCHECK is enabled (not just any valgrind tool).
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)

a discussion (no related file):
just to double-check - it only applies in this one place...? 😉


Copy link
Copy Markdown
Contributor

@kilobyte kilobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

a discussion (no related file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

just to double-check - it only applies in this one place...? 😉

Yeah — at least everything builds for me with stock valgrind (Debian unstable + clang12 from experimental).


@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2021

Codecov Report

Merging #1123 (783d6ee) into master (f5552be) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
+ Coverage   94.20%   94.26%   +0.05%     
==========================================
  Files          52       52              
  Lines        5301     5298       -3     
==========================================
  Hits         4994     4994              
+ Misses        307      304       -3     
Flag Coverage Δ
tests_clang_debug_cpp17 93.87% <100.00%> (+0.11%) ⬆️
tests_gcc_debug 90.97% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/experimental/radix_tree.hpp 98.43% <ø> (ø)
...nclude/libpmemobj++/experimental/inline_string.hpp 98.57% <100.00%> (-0.06%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.35% <0.00%> (+0.15%) ⬆️
include/libpmemobj++/mutex.hpp 86.20% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82bbb2...783d6ee. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk merged commit 3477efe into pmem:master Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants