Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

tests: do not use basic_string_view comparison as a workaround#1126

Merged
lukaszstolarczuk merged 1 commit intopmem:masterfrom
igchor:test_workaround
Jul 5, 2021
Merged

tests: do not use basic_string_view comparison as a workaround#1126
lukaszstolarczuk merged 1 commit intopmem:masterfrom
igchor:test_workaround

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Jul 5, 2021

for C2593: 'operator ==' is ambigous on Visual Studio 14.0


This change is Reviewable

for C2593: 'operator ==' is ambigous on Visual Studio 14.0
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igchor)

Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igchor)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 5, 2021

Codecov Report

Merging #1126 (07e0764) into master (2a8e855) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
+ Coverage   94.21%   94.23%   +0.01%     
==========================================
  Files          52       52              
  Lines        5325     5325              
==========================================
+ Hits         5017     5018       +1     
+ Misses        308      307       -1     
Flag Coverage Δ
tests_clang_debug_cpp17 93.77% <ø> (+0.07%) ⬆️
tests_gcc_debug 90.87% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...libpmemobj++/detail/enumerable_thread_specific.hpp 98.91% <0.00%> (-1.09%) ⬇️
include/libpmemobj++/container/vector.hpp 92.61% <0.00%> (ø)
include/libpmemobj++/experimental/radix_tree.hpp 98.43% <0.00%> (+0.14%) ⬆️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.20% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8e855...07e0764. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk merged commit 2543afa into pmem:master Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants