Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Conversation

@igchor
Copy link
Contributor

@igchor igchor commented Jul 6, 2021

Not only self_relative_ptr tests use atomics. On some platforms
(e.g. riscv64) -latomic is needed for a few other tests
(pool_cleanup, volatile_state).


This change is Reviewable

@igchor igchor force-pushed the fix_atomic branch 2 times, most recently from d89ce62 to 5203187 Compare July 6, 2021 13:29
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)

a discussion (no related file):
update readme with new tests' dependency...?


@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1132 (ea65a8e) into stable-1.11 (c68618e) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           stable-1.11    #1132      +/-   ##
===============================================
+ Coverage        95.86%   95.97%   +0.11%     
===============================================
  Files               48       48              
  Lines             6090     6090              
===============================================
+ Hits              5838     5845       +7     
+ Misses             252      245       -7     
Flag Coverage Δ
tests_clang_debug_cpp17 95.81% <ø> (+0.03%) ⬆️
tests_gcc_debug 92.54% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ibpmemobj++/detail/self_relative_ptr_base_impl.hpp 97.10% <0.00%> (-0.05%) ⬇️
include/libpmemobj++/experimental/radix_tree.hpp 99.32% <0.00%> (+<0.01%) ⬆️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.17% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68618e...ea65a8e. Read the comment docs.

Not only self_relative_ptr tests use atomics. On some platforms
(e.g. riscv64) -latomic is needed for a few other tests
(pool_cleanup, volatile_state).
@lukaszstolarczuk lukaszstolarczuk added this to the 1.11 milestone Jul 6, 2021
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igchor)

Copy link

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igchor)

@lukaszstolarczuk lukaszstolarczuk merged commit 2cecdec into pmem:stable-1.11 Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants