This repository was archived by the owner on Mar 22, 2023. It is now read-only.
riscv: define cacheline size#1153
Merged
lukaszstolarczuk merged 1 commit intopmem:masterfrom Jul 13, 2021
Merged
Conversation
igchor
approved these changes
Jul 12, 2021
Contributor
igchor
left a comment
igchor
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
+ Coverage 94.07% 94.11% +0.04%
==========================================
Files 52 52
Lines 5161 5163 +2
==========================================
+ Hits 4855 4859 +4
+ Misses 306 304 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
karczex
reviewed
Jul 13, 2021
karczex
left a comment
karczex
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaring the cacheline size is all that's needed to let the tests pass — of course assuming patched PMDK.
As this change is so non-intrusive, let's just commit and forget.
Among major lacking test dependencies there's valgrind (not ported yet) and libunwind (merged upstream, not released).
This change is