Conversation
next may be end() in case of the last key (or in case of concurrent erase).
it wasn't added during one of merge's. ref. 1c37736
igchor
left a comment
igchor
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
- Coverage 94.08% 94.07% -0.02%
==========================================
Files 52 52
Lines 5124 5115 -9
==========================================
- Hits 4821 4812 -9
Misses 303 303
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
KFilipek
left a comment
KFilipek
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
include/libpmemobj++/persistent_ptr.hpp, line 579 at r1 (raw file):
0xF00000000000000;
0xFDEADBEEF000000; still is a bit nerdy and better to debbuging
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewable status:
include/libpmemobj++/persistent_ptr.hpp, line 579 at r1 (raw file):
Previously, KFilipek (Krzysztof Filipek) wrote…
0xF00000000000000;
0xFDEADBEEF000000;still is a bit nerdy and better to debbuging
It's a cherry-pick from a stable branch actually, so I'd leave it as is.
KFilipek
left a comment
KFilipek
left a comment
There was a problem hiding this comment.
Reviewable status:
include/libpmemobj++/persistent_ptr.hpp, line 579 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
It's a cherry-pick from a stable branch actually, so I'd leave it as is.
That made me sad, but ok.
3 participants
two random fixes before rc 😉
This change is