Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

[stable-1.9] peristent_ptr: add missing offset calculation#1165

Merged
igchor merged 1 commit intopmem:stable-1.9from
lukaszstolarczuk:fix-pptr
Jul 21, 2021
Merged

[stable-1.9] peristent_ptr: add missing offset calculation#1165
igchor merged 1 commit intopmem:stable-1.9from
lukaszstolarczuk:fix-pptr

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Jul 19, 2021

it wasn't added during one of merge's.

ref. 1c37736


This change is Reviewable

it wasn't added during one of merge's.

ref. 1c37736
Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 19, 2021

Codecov Report

Merging #1165 (f8767aa) into stable-1.9 (cceee18) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.9    #1165      +/-   ##
==============================================
+ Coverage       87.49%   87.67%   +0.18%     
==============================================
  Files              40       40              
  Lines            3847     3847              
==============================================
+ Hits             3366     3373       +7     
+ Misses            481      474       -7     
Flag Coverage Δ
tests_clang_debug_cpp17 30.21% <ø> (-0.46%) ⬇️
tests_gcc_debug 93.75% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/persistent_ptr.hpp 96.32% <ø> (ø)
...ude/libpmemobj++/container/concurrent_hash_map.hpp 86.69% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cceee18...f8767aa. Read the comment docs.

@igchor igchor merged commit 825ab57 into pmem:stable-1.9 Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants