This repository was archived by the owner on Mar 22, 2023. It is now read-only.
[1.6] cmake: require c++11 for cow check#280
Merged
igchor merged 1 commit intopmem:stable-1.6from Apr 17, 2019
Merged
Conversation
Contributor
Contributor
|
stable-1.6? |
Codecov Report
@@ Coverage Diff @@
## stable-1.6 #280 +/- ##
==========================================
Coverage 96.5% 96.5%
==========================================
Files 30 30
Lines 2091 2091
==========================================
Hits 2018 2018
Misses 73 73
Continue to review full report at Codecov.
|
szyrom
approved these changes
Apr 10, 2019
szyrom
left a comment
szyrom
left a comment
There was a problem hiding this comment.
- stable 1.6
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
C++ version was incorrectly computed by cmake to c++98 which resulted in compilation error on ubuntu 16.04
kkajrewicz
changed the title
igchor
approved these changes
Apr 16, 2019
Contributor
igchor
left a comment
igchor
left a comment
There was a problem hiding this comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ version was incorrectly computed by cmake to c++98 which resulted in compilation error on ubuntu 16.04
This change is