Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

[1.6] Add missing include to v.hpp.#301

Merged
kkajrewicz merged 1 commit intopmem:stable-1.6from
igchor:stable-1.6-fix-v-include
May 22, 2019
Merged

[1.6] Add missing include to v.hpp.#301
kkajrewicz merged 1 commit intopmem:stable-1.6from
igchor:stable-1.6-fix-v-include

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented May 20, 2019

Needed by std::forward_as_tuple.


This change is Reviewable

@pmem-bot
Copy link
Copy Markdown
Contributor

@szyrom and @osalyk please review this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2019

Codecov Report

Merging #301 into stable-1.6 will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           stable-1.6    #301      +/-   ##
=============================================
+ Coverage       96.45%   96.5%   +0.05%     
=============================================
  Files              32      30       -2     
  Lines            3246    2091    -1155     
=============================================
- Hits             3131    2018    -1113     
+ Misses            115      73      -42
Flag Coverage Δ
#tests_clang_debug_cpp17 96.93% <ø> (+0.48%) ⬆️
#tests_gcc_debug 97.88% <ø> (+1.41%) ⬆️
#tests_gcc_release_cpp17_no_valgrind 96.63% <ø> (+1.06%) ⬆️
Impacted Files Coverage Δ
include/libpmemobj++/experimental/v.hpp 100% <ø> (ø) ⬆️
include/libpmemobj++/allocator.hpp 86.66% <0%> (-6.67%) ⬇️
include/libpmemobj++/experimental/vector.hpp 98.47% <0%> (-0.39%) ⬇️
include/libpmemobj++/experimental/basic_string.hpp 100% <0%> (ø) ⬆️
.../libpmemobj++/experimental/concurrent_hash_map.hpp
...nclude/libpmemobj++/detail/persistent_pool_ptr.hpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18bea23...40d7843. Read the comment docs.

@igchor igchor changed the title Add mising include to v.hpp. [1.6] Add mising include to v.hpp. May 20, 2019
Comment thread include/libpmemobj++/experimental/v.hpp
Needed by std::forward_as_tuple.
@igchor igchor force-pushed the stable-1.6-fix-v-include branch from 11817e2 to 40d7843 Compare May 21, 2019 12:00
@igchor igchor changed the title [1.6] Add mising include to v.hpp. [1.6] Add missing include to v.hpp. May 21, 2019
Copy link
Copy Markdown
Contributor

@kkajrewicz kkajrewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kkajrewicz)

Copy link
Copy Markdown
Contributor

@kkajrewicz kkajrewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kkajrewicz)

Copy link
Copy Markdown
Contributor

@kkajrewicz kkajrewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kkajrewicz kkajrewicz merged commit 458a7f7 into pmem:stable-1.6 May 22, 2019
@igchor igchor deleted the stable-1.6-fix-v-include branch October 7, 2019 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants