This repository was archived by the owner on Mar 22, 2023. It is now read-only.
[1.6] Mark allocation_flag constructor as explicit.#331
Merged
szyrom merged 1 commit intopmem:stable-1.6from Jun 24, 2019
Merged
[1.6] Mark allocation_flag constructor as explicit.#331szyrom merged 1 commit intopmem:stable-1.6from
szyrom merged 1 commit intopmem:stable-1.6from
Conversation
Having implicit constructor caused unexpected beahviour with make_persistent_array. For make_persistent version designed to work with sized arrays calling make_persistent<int[100]>(90) didn't failed as expected. Instead, '90' was implicitly converted to allocation_flag.
igchor
changed the title
Contributor
|
@szyrom and @lukaszstolarczuk please review this pull request |
Member
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
szyrom
approved these changes
Jun 24, 2019
szyrom
left a comment
szyrom
left a comment
There was a problem hiding this comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having implicit constructor caused unexpected beahviour with
make_persistent_array. For make_persistent version designed to
work with sized arrays calling make_persistent<int[100]>(90) didn't
failed as expected. Instead, '90' was implicitly converted to
allocation_flag.
This change is