This repository was archived by the owner on Mar 22, 2023. It is now read-only.
fix missing include header file#343
Merged
kkajrewicz merged 1 commit intopmem:stable-1.6from Jun 26, 2019
Merged
Conversation
Contributor
|
@kkajrewicz and @kilobyte please review this pull request |
stdexcept is needed in slice.hpp for std::out_of_range support
szyrom
force-pushed
the
fix_missing_header
branch
from
d59ca07 to
93784f5
Compare
igchor
approved these changes
Jun 25, 2019
Contributor
igchor
left a comment
igchor
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
marcinslusarz
approved these changes
Jun 25, 2019
Codecov Report
@@ Coverage Diff @@
## stable-1.6 #343 +/- ##
==============================================
+ Coverage 95.94% 96.03% +0.08%
==============================================
Files 32 32
Lines 3426 3175 -251
==============================================
- Hits 3287 3049 -238
+ Misses 139 126 -13
Continue to review full report at Codecov.
|
kkajrewicz
approved these changes
Jun 26, 2019
Contributor
kkajrewicz
left a comment
kkajrewicz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdexcept is needed in slice.hpp for std::out_of_range support
This change is