Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Install libpmemobj++.pc in all configurations#362

Merged
szyrom merged 1 commit intopmem:stable-1.5from
igchor:install_pkgconfigfile
Jul 5, 2019
Merged

Install libpmemobj++.pc in all configurations#362
szyrom merged 1 commit intopmem:stable-1.5from
igchor:install_pkgconfigfile

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Jul 5, 2019

This change is Reviewable

@pmem-bot
Copy link
Copy Markdown
Contributor

pmem-bot commented Jul 5, 2019

@annamarcink and @szyrom please review this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 5, 2019

Codecov Report

Merging #362 into stable-1.5 will decrease coverage by 5.53%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.5     #362      +/-   ##
==============================================
- Coverage       96.29%   90.76%   -5.54%     
==============================================
  Files              31       26       -5     
  Lines            2535     1050    -1485     
==============================================
- Hits             2441      953    -1488     
- Misses             94       97       +3
Flag Coverage Δ
#tests_clang_debug_cpp17 91.44% <ø> (-5.37%) ⬇️
#tests_clang_release 90.31% <ø> (ø) ⬆️
#tests_gcc_debug 93.39% <ø> (-4.03%) ⬇️
#tests_gcc_release_cpp17 89.39% <ø> (-6.15%) ⬇️
#tests_gcc_release_cpp17_no_valgrind ?
Impacted Files Coverage Δ
include/libpmemobj++/shared_mutex.hpp 64.44% <0%> (-16.16%) ⬇️
include/libpmemobj++/detail/pexceptions.hpp 71.42% <0%> (-16.08%) ⬇️
include/libpmemobj++/mutex.hpp 65.51% <0%> (-14.49%) ⬇️
include/libpmemobj++/timed_mutex.hpp 72.09% <0%> (-9.73%) ⬇️
include/libpmemobj++/detail/common.hpp 83.33% <0%> (-7.37%) ⬇️
include/libpmemobj++/transaction.hpp 89.87% <0%> (-6.03%) ⬇️
include/libpmemobj++/detail/make_atomic_impl.hpp 94.44% <0%> (-5.56%) ⬇️
include/libpmemobj++/make_persistent_atomic.hpp 90.9% <0%> (-4.93%) ⬇️
...lude/libpmemobj++/make_persistent_array_atomic.hpp 95.23% <0%> (-4.77%) ⬇️
include/libpmemobj++/detail/life.hpp 94.11% <0%> (-4.48%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d65051...597fd2a. Read the comment docs.

Copy link
Copy Markdown

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@szyrom szyrom merged commit 9f46ee2 into pmem:stable-1.5 Jul 5, 2019
@igchor igchor deleted the install_pkgconfigfile branch September 20, 2019 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants