[1.5] Do not check pkgconfig on windows#381
Conversation
|
@ldorau and @annamarcink please review this pull request |
40c6b5f to
1ac5c5d
Compare
ldorau
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
tbh, I don't get it - "it might be installed" so don't check it...?
Reviewable status:
complete! all files reviewed, all discussions resolved
igchor
left a comment
There was a problem hiding this comment.
It might be installed on windows but it's not what we want. It could be a part of cygwin for example, and we cannot use that. The only option is to never use pkg config on windows.
Reviewable status:
complete! all files reviewed, all discussions resolved
|
ok, thanks, so perhaps update the commit message, please |
ldorau
left a comment
There was a problem hiding this comment.
Please rebase, because Appveyor build is failing
Reviewable status:
complete! all files reviewed, all discussions resolved
it might be installed (as part of cygwin).
1ac5c5d to
fdb8bd1
Compare
Codecov Report
@@ Coverage Diff @@
## stable-1.5 #381 +/- ##
==============================================
- Coverage 90.76% 88.69% -2.07%
==============================================
Files 26 26
Lines 1050 867 -183
==============================================
- Hits 953 769 -184
- Misses 97 98 +1
Continue to review full report at Codecov.
|
it might be installed (as part of cygwin).
This change is