Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

[1.5] Do not check pkgconfig on windows#381

Merged
igchor merged 1 commit intopmem:stable-1.5from
igchor:stable-1.5_pkg_config_fix
Sep 9, 2019
Merged

[1.5] Do not check pkgconfig on windows#381
igchor merged 1 commit intopmem:stable-1.5from
igchor:stable-1.5_pkg_config_fix

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Aug 1, 2019

it might be installed (as part of cygwin).


This change is Reviewable

@igchor igchor changed the title Do not check pkgconfig on windows [1.5] Do not check pkgconfig on windows Aug 1, 2019
@pmem-bot
Copy link
Copy Markdown
Contributor

pmem-bot commented Aug 1, 2019

@ldorau and @annamarcink please review this pull request

@igchor igchor force-pushed the stable-1.5_pkg_config_fix branch from 40c6b5f to 1ac5c5d Compare August 1, 2019 14:46
Copy link
Copy Markdown
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, I don't get it - "it might be installed" so don't check it...?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor Author

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be installed on windows but it's not what we want. It could be a part of cygwin for example, and we cannot use that. The only option is to never use pkg config on windows.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukaszstolarczuk
Copy link
Copy Markdown
Member

ok, thanks, so perhaps update the commit message, please

Copy link
Copy Markdown
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, because Appveyor build is failing

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

it might be installed (as part of cygwin).
@igchor igchor force-pushed the stable-1.5_pkg_config_fix branch from 1ac5c5d to fdb8bd1 Compare September 9, 2019 08:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2019

Codecov Report

Merging #381 into stable-1.5 will decrease coverage by 2.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.5     #381      +/-   ##
==============================================
- Coverage       90.76%   88.69%   -2.07%     
==============================================
  Files              26       26              
  Lines            1050      867     -183     
==============================================
- Hits              953      769     -184     
- Misses             97       98       +1
Flag Coverage Δ
#tests_clang_debug_cpp17 91.44% <ø> (ø) ⬆️
#tests_clang_release 90.31% <ø> (ø) ⬆️
#tests_gcc_debug ?
#tests_gcc_release_cpp17 89.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
include/libpmemobj++/condition_variable.hpp 81.15% <0%> (-4.18%) ⬇️
include/libpmemobj++/mutex.hpp 62.96% <0%> (-2.56%) ⬇️
include/libpmemobj++/shared_mutex.hpp 61.9% <0%> (-2.54%) ⬇️
include/libpmemobj++/pool.hpp 89.58% <0%> (-2.49%) ⬇️
include/libpmemobj++/p.hpp 92.3% <0%> (-2.14%) ⬇️
include/libpmemobj++/allocator.hpp 84.61% <0%> (-2.06%) ⬇️
include/libpmemobj++/persistent_ptr.hpp 93.67% <0%> (-1.79%) ⬇️
include/libpmemobj++/detail/common.hpp 81.81% <0%> (-1.52%) ⬇️
include/libpmemobj++/experimental/v.hpp 94.44% <0%> (-1.02%) ⬇️
include/libpmemobj++/timed_mutex.hpp 71.42% <0%> (-0.67%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a04c2...fdb8bd1. Read the comment docs.

@igchor igchor merged commit 768da42 into pmem:stable-1.5 Sep 9, 2019
@igchor igchor deleted the stable-1.5_pkg_config_fix branch October 7, 2019 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants