Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Merge changes from stable-1.5#567

Merged
igchor merged 2 commits intostable-1.6from
stable-1.5
Dec 24, 2019
Merged

Merge changes from stable-1.5#567
igchor merged 2 commits intostable-1.6from
stable-1.5

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Dec 24, 2019

This change is Reviewable

Including libpmemobj.h causes inclusion of all type macros
which are not needed by C++.
allocator: remove unnecessary #include <libpmemobj.h>
@pmem-bot
Copy link
Copy Markdown
Contributor

@karczex and @szyrom please review this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 24, 2019

Codecov Report

Merging #567 into stable-1.6 will increase coverage by 7.65%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.6     #567      +/-   ##
==============================================
+ Coverage       88.69%   96.35%   +7.65%     
==============================================
  Files              26       31       +5     
  Lines             867     2551    +1684     
==============================================
+ Hits              769     2458    +1689     
+ Misses             98       93       -5
Flag Coverage Δ
#tests_clang_debug_cpp17 96.88% <ø> (+5.44%) ⬆️
#tests_clang_release 90.31% <ø> (ø) ⬆️
#tests_gcc_debug 97.43% <ø> (?)
#tests_gcc_release_cpp17 95.57% <ø> (+6.17%) ⬆️
#tests_gcc_release_cpp17_no_valgrind 96.63% <ø> (?)
Impacted Files Coverage Δ
include/libpmemobj++/allocator.hpp 90.9% <ø> (+6.29%) ⬆️
include/libpmemobj++/make_persistent.hpp 88.57% <0%> (-1.91%) ⬇️
include/libpmemobj++/detail/life.hpp 98.59% <0%> (-1.41%) ⬇️
include/libpmemobj++/detail/conversions.hpp 100% <0%> (ø) ⬆️
include/libpmemobj++/experimental/slice.hpp 100% <0%> (ø) ⬆️
.../libpmemobj++/experimental/contiguous_iterator.hpp 100% <0%> (ø) ⬆️
include/libpmemobj++/experimental/array.hpp 100% <0%> (ø) ⬆️
include/libpmemobj++/pext.hpp 100% <0%> (ø) ⬆️
include/libpmemobj++/allocation_flag.hpp 100% <0%> (ø)
include/libpmemobj++/detail/temp_value.hpp 100% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768da42...a0de231. Read the comment docs.

@igchor igchor merged commit 5e25c75 into stable-1.6 Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants