Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Conversation

@igchor
Copy link
Contributor

@igchor igchor commented Jan 31, 2020

This change is Reviewable

@pmem-bot
Copy link
Contributor

@karczex and @szyrom please review this pull request

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #651 into master will increase coverage by 1.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #651     +/-   ##
=========================================
+ Coverage   95.86%   97.06%   +1.2%     
=========================================
  Files          40       34      -6     
  Lines        4131     4055     -76     
=========================================
- Hits         3960     3936     -24     
+ Misses        171      119     -52
Flag Coverage Δ
#tests_clang_debug_cpp17 97.04% <ø> (+1.14%) ⬆️
#tests_gcc_debug 94.01% <ø> (+0.96%) ⬆️
Impacted Files Coverage Δ
include/libpmemobj++/mutex.hpp 80% <0%> (-6.96%) ⬇️
include/libpmemobj++/make_persistent.hpp 85.18% <0%> (-6.49%) ⬇️
include/libpmemobj++/timed_mutex.hpp 81.81% <0%> (-5.28%) ⬇️
include/libpmemobj++/shared_mutex.hpp 85.41% <0%> (-4.06%) ⬇️
include/libpmemobj++/allocator.hpp 93.33% <0%> (-2.5%) ⬇️
include/libpmemobj++/container/basic_string.hpp 99.62% <0%> (-0.11%) ⬇️
include/libpmemobj++/detail/life.hpp 98.3% <0%> (-0.03%) ⬇️
...nclude/libpmemobj++/detail/persistent_pool_ptr.hpp 100% <0%> (ø) ⬆️
include/libpmemobj++/detail/ctl.hpp 100% <0%> (ø) ⬆️
...libpmemobj++/detail/enumerable_thread_specific.hpp
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ade87...58f83bb. Read the comment docs.

@szyrom szyrom merged commit 4a475b6 into pmem:master Jan 31, 2020
@igchor igchor deleted the merge1.8 branch February 12, 2020 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants