Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Only parse libpmemobj version if it matches a pattern (major[.]minor.*)#667

Merged
szyrom merged 1 commit intopmem:stable-1.7from
igchor:fix_obj_version
Feb 26, 2020
Merged

Only parse libpmemobj version if it matches a pattern (major[.]minor.*)#667
szyrom merged 1 commit intopmem:stable-1.7from
igchor:fix_obj_version

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Feb 19, 2020 •
edited by marcinslusarz
Loading

Ref: #377

This change is Reviewable

@pmem-bot
Copy link
Copy Markdown
Contributor

pmem-bot commented Feb 19, 2020

@lukaszstolarczuk and @szyrom please review this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2020 •
edited
Loading

Codecov Report

Merging #667 into stable-1.7 will decrease coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.7     #667      +/-   ##
==============================================
- Coverage       96.24%   95.43%   -0.82%     
==============================================
  Files              32       32              
  Lines            3196     3196              
==============================================
- Hits             3076     3050      -26     
- Misses            120      146      +26
Flag Coverage Δ
#tests_clang_debug_cpp17 96.18% <ø> (-0.84%) ⬇️
#tests_gcc_debug 93.89% <ø> (-0.84%) ⬇️
#tests_gcc_release_cpp17_no_valgrind 80.06% <ø> (+0.15%) ⬆️
Impacted Files Coverage Δ
.../libpmemobj++/experimental/concurrent_hash_map.hpp 91.26% <0%> (-3.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d66e8...3cf91bd. Read the comment docs.

lukaszstolarczuk
lukaszstolarczuk approved these changes Feb 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor requested a review from marcinslusarz February 20, 2020 09:57
lukaszstolarczuk
lukaszstolarczuk reviewed Feb 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @marcinslusarz)

szyrom
szyrom approved these changes Feb 26, 2020
View reviewed changes
Copy link
Copy Markdown

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @marcinslusarz)

@szyrom szyrom merged commit 39842b7 into pmem:stable-1.7 Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marcinslusarz marcinslusarz Awaiting requested review from marcinslusarz

2 more reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@szyrom szyrom szyrom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igchor @pmem-bot @szyrom @lukaszstolarczuk