Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Merge stable-1.6 into stable-1.7#674

Merged
igchor merged 5 commits intostable-1.7from
stable-1.6
Feb 28, 2020
Merged

Merge stable-1.6 into stable-1.7#674
igchor merged 5 commits intostable-1.7from
stable-1.6

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Feb 27, 2020

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2020

Codecov Report

Merging #674 into stable-1.7 will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.7     #674      +/-   ##
==============================================
+ Coverage        96.5%   96.67%   +0.16%     
==============================================
  Files              30       32       +2     
  Lines            2091     3484    +1393     
==============================================
+ Hits             2018     3368    +1350     
- Misses             73      116      +43
Flag Coverage Δ
#tests_clang_debug_cpp17 97.25% <ø> (+0.32%) ⬆️
#tests_gcc_debug 95.57% <ø> (-2.31%) ⬇️
#tests_gcc_release_cpp17_no_valgrind 86.47% <ø> (?)
Impacted Files Coverage Δ
include/libpmemobj++/experimental/basic_string.hpp 99.88% <0%> (-0.12%) ⬇️
include/libpmemobj++/make_persistent_atomic.hpp 100% <0%> (ø) ⬆️
.../libpmemobj++/experimental/concurrent_hash_map.hpp 94.55% <0%> (ø)
...nclude/libpmemobj++/detail/persistent_pool_ptr.hpp 96.15% <0%> (ø)
include/libpmemobj++/make_persistent.hpp 91.89% <0%> (+0.22%) ⬆️
include/libpmemobj++/experimental/vector.hpp 98.85% <0%> (+0.38%) ⬆️
include/libpmemobj++/allocator.hpp 93.33% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2e015...8a14df5. Read the comment docs.

Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor merged commit 9e7e29d into stable-1.7 Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants