This repository was archived by the owner on Mar 22, 2023. It is now read-only.
Merge stable-1.6 into stable-1.7#724
Merged
szyrom merged 4 commits intostable-1.7from Apr 17, 2020
Merged
Conversation
of unsigned. The reason is that Windows cannot decide for a call like this: `it[0] = 10` whether to use: * operator[](unsigned) -- one conversion from signed to unsigned * operator T*() and then build in operator[](signed) -- one conversion
contigous_iterator: make operator[] take signed integral instead
Merge stable 1.5 into stable 1.6
Codecov Report
@@ Coverage Diff @@
## stable-1.7 #724 +/- ##
===========================================
Coverage 96.67% 96.67%
===========================================
Files 32 32
Lines 3484 3486 +2
===========================================
+ Hits 3368 3370 +2
Misses 116 116
Continue to review full report at Codecov.
|
lukaszstolarczuk
approved these changes
Apr 17, 2020
Member
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
szyrom
approved these changes
Apr 17, 2020
szyrom
left a comment
szyrom
left a comment
There was a problem hiding this comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is