Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

get rid of old WA for vcpkg and use latest release instead#787

Merged
szyrom merged 1 commit intopmem:stable-1.9from
lukaszstolarczuk:fix-vcpkg-issue
Jun 18, 2020
Merged

get rid of old WA for vcpkg and use latest release instead#787
szyrom merged 1 commit intopmem:stable-1.9from
lukaszstolarczuk:fix-vcpkg-issue

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Jun 16, 2020

ref. #785 - it's also required on stable-1.9 and -1.10


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2020

Codecov Report

Merging #787 into stable-1.9 will decrease coverage by 14.31%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           stable-1.9     #787       +/-   ##
===============================================
- Coverage       95.94%   81.62%   -14.32%     
===============================================
  Files              40       40               
  Lines            4145     3794      -351     
===============================================
- Hits             3977     3097      -880     
- Misses            168      697      +529     
Flag Coverage Δ
#tests_clang_debug_cpp17 71.70% <ø> (-24.18%) ⬇️
#tests_gcc_debug 79.36% <ø> (-13.93%) ⬇️
Impacted Files Coverage Δ
include/libpmemobj++/detail/conversions.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/libpmemobj++/timed_mutex.hpp 0.00% <0.00%> (-87.10%) ⬇️
include/libpmemobj++/condition_variable.hpp 0.00% <0.00%> (-78.27%) ⬇️
include/libpmemobj++/detail/pair.hpp 37.50% <0.00%> (-62.50%) ⬇️
include/libpmemobj++/pexceptions.hpp 5.55% <0.00%> (-48.69%) ⬇️
include/libpmemobj++/detail/life.hpp 60.00% <0.00%> (-38.34%) ⬇️
include/libpmemobj++/defrag.hpp 54.54% <0.00%> (-37.77%) ⬇️
include/libpmemobj++/mutex.hpp 54.54% <0.00%> (-32.42%) ⬇️
include/libpmemobj++/transaction.hpp 61.53% <0.00%> (-25.60%) ⬇️
include/libpmemobj++/persistent_ptr_base.hpp 76.00% <0.00%> (-24.00%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61afb6a...278be2d. Read the comment docs.

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@szyrom szyrom merged commit 8dc9c20 into pmem:stable-1.9 Jun 18, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the fix-vcpkg-issue branch June 18, 2020 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants