Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

concurrent_hash_map: make double to size_t cast explicit in defragment()#860

Merged
szyrom merged 1 commit intopmem:stable-1.9from
igchor:stable-1.9_defrag_fix
Sep 11, 2020
Merged

concurrent_hash_map: make double to size_t cast explicit in defragment()#860
szyrom merged 1 commit intopmem:stable-1.9from
igchor:stable-1.9_defrag_fix

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Sep 10, 2020

and make sure only indexes up to max_index are used.


This change is Reviewable

and make sure only indexes up to max_index are used.
@igchor igchor force-pushed the stable-1.9_defrag_fix branch from 57a653b to 415e8b9 Compare September 10, 2020 10:39
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 10, 2020

Codecov Report

Merging #860 into stable-1.9 will decrease coverage by 3.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.9     #860      +/-   ##
==============================================
- Coverage       96.13%   92.22%   -3.92%     
==============================================
  Files              40       40              
  Lines            4144     3792     -352     
==============================================
- Hits             3984     3497     -487     
- Misses            160      295     +135     
Flag Coverage Δ
#tests_clang_debug_cpp17 71.74% <0.00%> (-24.42%) ⬇️
#tests_gcc_debug 93.74% <100.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.35% <100.00%> (-1.36%) ⬇️
include/libpmemobj++/detail/conversions.hpp 0.00% <0.00%> (-100.00%) ⬇️
include/libpmemobj++/timed_mutex.hpp 54.83% <0.00%> (-32.26%) ⬇️
include/libpmemobj++/pexceptions.hpp 33.33% <0.00%> (-20.91%) ⬇️
include/libpmemobj++/defrag.hpp 72.72% <0.00%> (-19.59%) ⬇️
include/libpmemobj++/detail/atomic_backoff.hpp 31.81% <0.00%> (-18.19%) ⬇️
include/libpmemobj++/shared_mutex.hpp 77.77% <0.00%> (-11.70%) ⬇️
include/libpmemobj++/make_persistent.hpp 80.76% <0.00%> (-11.54%) ⬇️
include/libpmemobj++/condition_variable.hpp 67.39% <0.00%> (-10.87%) ⬇️
include/libpmemobj++/container/vector.hpp 87.90% <0.00%> (-10.25%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa72466...415e8b9. Read the comment docs.

Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@szyrom szyrom merged commit d346272 into pmem:stable-1.9 Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants