This repository was archived by the owner on Mar 22, 2023. It is now read-only.
tests: fix parallel_exec_with sync implementation#898
Merged
szyrom merged 1 commit intopmem:stable-1.9from Sep 29, 2020
Merged
Conversation
Since std::condition_variable::wait can wakeup spuriosly we need to pass a predicate to wait.
igchor
force-pushed
the
spurious_wakepup_fix_1.9
branch
from
40cb14a to
e21c502
Compare
lukaszstolarczuk
approved these changes
Sep 28, 2020
Member
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## stable-1.9 #898 +/- ##
===============================================
- Coverage 92.19% 71.79% -20.40%
===============================================
Files 40 39 -1
Lines 3792 1826 -1966
===============================================
- Hits 3496 1311 -2185
- Misses 296 515 +219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since std::condition_variable::wait can wakeup spuriosly we need to
pass a predicate to wait. Without this fix, enumerable_thread_specific tests can fail randomly since some of them require a specific number of threads to be active.
This change is