cmake: look for libpmemobj also when building benchmarks#904
cmake: look for libpmemobj also when building benchmarks#904szyrom merged 1 commit intopmem:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 95.95% 95.89% -0.07%
==========================================
Files 48 48
Lines 6083 6085 +2
==========================================
- Hits 5837 5835 -2
- Misses 246 250 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
szyrom
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
igchor
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
CMakeLists.txt, line 146 at r1 (raw file):
endif() if(PKG_CONFIG_FOUND)
Hm, what about doc?
igchor
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukaszstolarczuk)
CMakeLists.txt, line 146 at r1 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
Hm, what about doc?
For now, we do not need to have libpmemobj if we only want to build documentation. I think I would prefer to have a similar if as in vcpkg (for examples, tests and benchmarks).
CMakeLists.txt, line 154 at r1 (raw file):
endif() if(BUILD_TESTS OR BUILD_EXAMPLES)
should this also include benchmarks?
f4768cd to
ec453e4
Compare
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @igchor)
CMakeLists.txt, line 146 at r1 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
For now, we do not need to have libpmemobj if we only want to build documentation. I think I would prefer to have a similar if as in vcpkg (for examples, tests and benchmarks).
Done.
CMakeLists.txt, line 154 at r1 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
should this also include benchmarks?
Done. I've added all of them under the same if
igchor
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @szyrom)
rather than just for tests and examples.
ref. https://github.com/microsoft/vcpkg/blob/master/ports/libpmemobj-cpp/fixlibpmemobj-cpp.patch
This change is