Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

cmake: look for libpmemobj also when building benchmarks#904

Merged
szyrom merged 1 commit intopmem:masterfrom
lukaszstolarczuk:always-find-libpmemobj
Sep 30, 2020
Merged

cmake: look for libpmemobj also when building benchmarks#904
szyrom merged 1 commit intopmem:masterfrom
lukaszstolarczuk:always-find-libpmemobj

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Sep 30, 2020

rather than just for tests and examples.

ref. https://github.com/microsoft/vcpkg/blob/master/ports/libpmemobj-cpp/fixlibpmemobj-cpp.patch


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2020

Codecov Report

Merging #904 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   95.95%   95.89%   -0.07%     
==========================================
  Files          48       48              
  Lines        6083     6085       +2     
==========================================
- Hits         5837     5835       -2     
- Misses        246      250       +4     
Flag Coverage Δ
#tests_clang_debug_cpp17 95.83% <ø> (-0.02%) ⬇️
#tests_gcc_debug 92.36% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ude/libpmemobj++/container/concurrent_hash_map.hpp 93.46% <0.00%> (-0.41%) ⬇️
include/libpmemobj++/experimental/radix_tree.hpp 99.45% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b23f2...ec453e4. Read the comment docs.

Copy link
Copy Markdown

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)


CMakeLists.txt, line 146 at r1 (raw file):

endif()

if(PKG_CONFIG_FOUND)

Hm, what about doc?

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukaszstolarczuk)


CMakeLists.txt, line 146 at r1 (raw file):

Previously, igchor (Igor Chorążewicz) wrote…

Hm, what about doc?

For now, we do not need to have libpmemobj if we only want to build documentation. I think I would prefer to have a similar if as in vcpkg (for examples, tests and benchmarks).


CMakeLists.txt, line 154 at r1 (raw file):

endif()

if(BUILD_TESTS OR BUILD_EXAMPLES)

should this also include benchmarks?

Copy link
Copy Markdown
Member Author

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @igchor)


CMakeLists.txt, line 146 at r1 (raw file):

Previously, igchor (Igor Chorążewicz) wrote…

For now, we do not need to have libpmemobj if we only want to build documentation. I think I would prefer to have a similar if as in vcpkg (for examples, tests and benchmarks).

Done.


CMakeLists.txt, line 154 at r1 (raw file):

Previously, igchor (Igor Chorążewicz) wrote…

should this also include benchmarks?

Done. I've added all of them under the same if

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @szyrom)

@lukaszstolarczuk lukaszstolarczuk changed the title cmake: always look for libpmemobj cmake: look for libpmemobj also when building benchmarks Sep 30, 2020
@szyrom szyrom merged commit 2b08da4 into pmem:master Sep 30, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the always-find-libpmemobj branch September 30, 2020 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants