Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Move Coverity job to GHA#917

Merged
lukaszstolarczuk merged 3 commits intopmem:masterfrom
lukaszstolarczuk:move-coverity-to-gha
Oct 14, 2020
Merged

Move Coverity job to GHA#917
lukaszstolarczuk merged 3 commits intopmem:masterfrom
lukaszstolarczuk:move-coverity-to-gha

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Oct 5, 2020


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2020

Codecov Report

Merging #917 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
- Coverage   95.94%   95.90%   -0.05%     
==========================================
  Files          48       48              
  Lines        6122     6122              
==========================================
- Hits         5874     5871       -3     
- Misses        248      251       +3     
Flag Coverage Δ
#tests_clang_debug_cpp17 95.84% <ø> (-0.04%) ⬇️
#tests_gcc_debug 92.29% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/condition_variable.hpp 73.80% <0.00%> (-4.77%) ⬇️
...j++/container/detail/concurrent_skip_list_impl.hpp 97.99% <0.00%> (-0.14%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 93.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216012a...c0d4cf5. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review October 9, 2020 10:01
@lukaszstolarczuk
Copy link
Copy Markdown
Member Author

it works just fine on pmemkv, I believe: https://scan.coverity.com/projects/pmem-pmemkv

Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)


travis.yml, line 11 at r1 (raw file):

# currently, Travis is turned off - all jobs run on GHA
if: false

pls, remove this file in separate commit, to be able revert it easily, instead of making intentionally dead code.

Copy link
Copy Markdown
Member Author

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @karczex and @KFilipek)


travis.yml, line 11 at r1 (raw file):

Previously, karczex wrote…

pls, remove this file in separate commit, to be able revert it easily, instead of making intentionally dead code.

Done.

Copy link
Copy Markdown

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 6 files at r1, 2 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karczex)

Copy link
Copy Markdown

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukaszstolarczuk lukaszstolarczuk merged commit 19b0f3d into pmem:master Oct 14, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the move-coverity-to-gha branch October 14, 2020 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants