Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Radix tree assing val fix#918

Merged
lukaszstolarczuk merged 2 commits intopmem:stable-1.11from
igchor:radix_tree_assing_val_fix
Oct 6, 2020
Merged

Radix tree assing val fix#918
lukaszstolarczuk merged 2 commits intopmem:stable-1.11from
igchor:radix_tree_assing_val_fix

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Oct 6, 2020 •
edited by marcinslusarz
Loading

This change is Reviewable

KFilipek
KFilipek reviewed Oct 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor force-pushed the radix_tree_assing_val_fix branch from 30be7a7 to e693e93 Compare October 6, 2020 08:31
KFilipek
KFilipek reviewed Oct 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

lukaszstolarczuk
lukaszstolarczuk reviewed Oct 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor force-pushed the radix_tree_assing_val_fix branch from e693e93 to 1aafc9b Compare October 6, 2020 09:03
igchor added 2 commits October 6, 2020 11:04
@igchor
radix_tree: fix assing_val
aff4ddb 
Realocating path should be taken for values which are instances
of basic_inline_string<CharT, Traits> (not only for CharT = char).
@igchor
tests: fix radix_tx_abort test
d58afc4 
Fix value() function which was creating an empty string (wrong input parameter)
and add testcases for basic_inline_string<uint8_t> and basic_inline_string<wchar_t>
as value types.
@igchor igchor force-pushed the radix_tree_assing_val_fix branch from 1aafc9b to d58afc4 Compare October 6, 2020 09:05
@igchor igchor changed the base branch from master to stable-1.11 October 6, 2020 09:05
szyrom
szyrom approved these changes Oct 6, 2020
View reviewed changes
Copy link
Copy Markdown

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2020 •
edited
Loading

Codecov Report

Merging #918 into stable-1.11 will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           stable-1.11     #918      +/-   ##
===============================================
- Coverage        95.97%   95.87%   -0.10%     
===============================================
  Files               48       48              
  Lines             6087     6087              
===============================================
- Hits              5842     5836       -6     
- Misses             245      251       +6
Flag Coverage Δ
#tests_clang_debug_cpp17 95.81% <ø> (-0.14%) ⬇️
#tests_gcc_debug 92.33% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/experimental/radix_tree.hpp 99.45% <ø> (ø)
include/libpmemobj++/mutex.hpp 79.31% <0.00%> (-6.90%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 93.36% <0.00%> (-0.61%) ⬇️
include/libpmemobj++/condition_variable.hpp 78.57% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26da8fa...d58afc4. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk merged commit df53b56 into pmem:stable-1.11 Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@KFilipek KFilipek KFilipek left review comments

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk left review comments

@szyrom szyrom szyrom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igchor @KFilipek @szyrom @lukaszstolarczuk