Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Conversation

@lukaszstolarczuk
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk commented Oct 6, 2020

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #921 into stable-1.11 will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           stable-1.11     #921      +/-   ##
===============================================
- Coverage        96.12%   95.87%   -0.25%     
===============================================
  Files               48       48              
  Lines             6087     6087              
===============================================
- Hits              5851     5836      -15     
- Misses             236      251      +15     
Flag Coverage Δ
#tests_clang_debug_cpp17 95.74% <ø> (-0.21%) ⬇️
#tests_gcc_debug 92.35% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/mutex.hpp 79.31% <0.00%> (-6.90%) ⬇️
include/libpmemobj++/condition_variable.hpp 76.19% <0.00%> (-2.39%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 93.46% <0.00%> (-1.11%) ⬇️
...j++/container/detail/concurrent_skip_list_impl.hpp 97.99% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd6a8b...851b478. Read the comment docs.

Copy link
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor merged commit 1a54830 into pmem:stable-1.11 Oct 6, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the fix-docs-GHA-job branch October 6, 2020 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants