Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

examples: update min cmake version to 3.4#922

Merged
igchor merged 1 commit intopmem:masterfrom
lukaszstolarczuk:update-cmake-min-ver
Oct 8, 2020
Merged

examples: update min cmake version to 3.4#922
igchor merged 1 commit intopmem:masterfrom
lukaszstolarczuk:update-cmake-min-ver

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Oct 6, 2020

in examples using 'include' command - it also uses 'CheckIncludeFile'
which (in CMake <=3.3) worked only with set project language (CXX in this case),
and some included files are supposed to be checked with C lang, too.

With help of: https://github.com/nlohmann/cmake_min_version


This change is Reviewable

in examples using 'include' command - it also uses 'CheckIncludeFile'
which (in CMake <=3.3) worked only with set project language (CXX in this case),
and some included files are supposed to be checked with C lang, too.

With help of: https://github.com/nlohmann/cmake_min_version
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 6, 2020

Codecov Report

Merging #922 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
- Coverage   95.99%   95.90%   -0.09%     
==========================================
  Files          48       48              
  Lines        6087     6087              
==========================================
- Hits         5843     5838       -5     
- Misses        244      249       +5     
Flag Coverage Δ
#tests_clang_debug_cpp17 95.83% <ø> (ø)
#tests_gcc_debug 92.38% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/mutex.hpp 79.31% <0.00%> (-6.90%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 93.66% <0.00%> (-0.41%) ⬇️
...j++/container/detail/concurrent_skip_list_impl.hpp 98.12% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17533fe...e7cb495. Read the comment docs.

Copy link
Copy Markdown

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update main README

Reviewed 17 of 17 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor merged commit 3a849de into pmem:master Oct 8, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the update-cmake-min-ver branch October 8, 2020 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants