This repository was archived by the owner on Mar 22, 2023. It is now read-only.
examples: update min cmake version to 3.4#922
Merged
igchor merged 1 commit intopmem:masterfrom Oct 8, 2020
Merged
Conversation
in examples using 'include' command - it also uses 'CheckIncludeFile' which (in CMake <=3.3) worked only with set project language (CXX in this case), and some included files are supposed to be checked with C lang, too. With help of: https://github.com/nlohmann/cmake_min_version
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
==========================================
- Coverage 95.99% 95.90% -0.09%
==========================================
Files 48 48
Lines 6087 6087
==========================================
- Hits 5843 5838 -5
- Misses 244 249 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
szyrom
approved these changes
Oct 7, 2020
szyrom
left a comment
There was a problem hiding this comment.
please update main README
Reviewed 17 of 17 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in examples using 'include' command - it also uses 'CheckIncludeFile'
which (in CMake <=3.3) worked only with set project language (CXX in this case),
and some included files are supposed to be checked with C lang, too.
With help of: https://github.com/nlohmann/cmake_min_version
This change is