Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

CI: use special environment var in GHA for Windows' PATH#981

Merged
igchor merged 1 commit intopmem:stable-1.9from
lukaszstolarczuk:fix-gha-windows-add-path
Nov 24, 2020
Merged

CI: use special environment var in GHA for Windows' PATH#981
igchor merged 1 commit intopmem:stable-1.9from
lukaszstolarczuk:fix-gha-windows-add-path

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented Nov 23, 2020

The old 'addPath' is depreciated now. For more details see:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

mea culpa, this is a merge back from #975 - this should have been based on the oldest branch with GHA enabled, from the beginning.


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 23, 2020

Codecov Report

Merging #981 (83fa6fa) into stable-1.9 (db5da1b) will increase coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-1.9     #981      +/-   ##
==============================================
+ Coverage       92.16%   93.34%   +1.17%     
==============================================
  Files              40       40              
  Lines            3792     3815      +23     
==============================================
+ Hits             3495     3561      +66     
+ Misses            297      254      -43     
Flag Coverage Δ
tests_clang_debug_cpp17 80.63% <ø> (+9.00%) ⬆️
tests_gcc_debug 93.74% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.08% <0.00%> (-0.07%) ⬇️
include/libpmemobj++/container/array.hpp 100.00% <0.00%> (ø)
include/libpmemobj++/detail/temp_value.hpp 100.00% <0.00%> (ø)
...lude/libpmemobj++/make_persistent_array_atomic.hpp 100.00% <0.00%> (ø)
include/libpmemobj++/container/basic_string.hpp 96.64% <0.00%> (+0.31%) ⬆️
include/libpmemobj++/detail/common.hpp 88.23% <0.00%> (+0.35%) ⬆️
include/libpmemobj++/container/segment_vector.hpp 95.22% <0.00%> (+0.74%) ⬆️
include/libpmemobj++/container/vector.hpp 93.51% <0.00%> (+5.60%) ⬆️
include/libpmemobj++/make_persistent_atomic.hpp 100.00% <0.00%> (+9.09%) ⬆️
include/libpmemobj++/timed_mutex.hpp 87.09% <0.00%> (+32.25%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5da1b...83fa6fa. Read the comment docs.

@igchor igchor merged commit 4884e82 into pmem:stable-1.9 Nov 24, 2020
@lukaszstolarczuk lukaszstolarczuk deleted the fix-gha-windows-add-path branch November 24, 2020 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants