Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Bump required version of libpmemobj#998

Merged
lukaszstolarczuk merged 1 commit intopmem:masterfrom
igchor:bump_obj
Dec 18, 2020
Merged

Bump required version of libpmemobj#998
lukaszstolarczuk merged 1 commit intopmem:masterfrom
igchor:bump_obj

Conversation

@igchor
Copy link
Copy Markdown
Contributor

@igchor igchor commented Dec 18, 2020

Since introducing flat_transactions, 1.9 is needed.


This change is Reviewable

Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igchor)

Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)

a discussion (no related file):
pls bump also PMDK_VERSION in gha.yml (Win build)


Since introducing flat_transactions, 1.9 is needed.
Copy link
Copy Markdown
Contributor Author

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)

a discussion (no related file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

pls bump also PMDK_VERSION in gha.yml (Win build)

Done.


@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2020

Codecov Report

Merging #998 (12d4e60) into master (480c990) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
+ Coverage   95.72%   95.86%   +0.14%     
==========================================
  Files          48       48              
  Lines        6291     6291              
==========================================
+ Hits         6022     6031       +9     
+ Misses        269      260       -9     
Flag Coverage Δ
tests_clang_debug_cpp17 95.45% <ø> (+0.24%) ⬆️
tests_gcc_debug 92.47% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.21% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 480c990...ef6ffa8. Read the comment docs.

Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igchor)

@lukaszstolarczuk lukaszstolarczuk merged commit bc2fd84 into pmem:master Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants