Skip to content

common: docker/Dockerfile and scripts/README.md fixes and improvements#6

Merged
lukaszstolarczuk merged 1 commit intopmemhackathon:mainfrom
lukaszstolarczuk:scripts-README-fixes
Sep 9, 2022
Merged

common: docker/Dockerfile and scripts/README.md fixes and improvements#6
lukaszstolarczuk merged 1 commit intopmemhackathon:mainfrom
lukaszstolarczuk:scripts-README-fixes

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Sep 9, 2022

continuation of Janek's work (see original PR: pmemhackathon/2021-04-21.web#6)


This change is Reviewable

Copy link
Copy Markdown
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @ldorau and @lukaszstolarczuk)


docker/Dockerfile line 4 at r1 (raw file):

# dockerfile for pmemhackathon, fc30 based
#
# Note: After making changes to files within this directory you have to rebuild

After having made changes ...

Code quote:

After making changes

scripts/README.md line 14 at r1 (raw file):

Note: The command above copies part of the source tree to the hackathon home directory

hackathon's

Code quote:

hackathon

scripts/README.md line 28 at r1 (raw file):

  1. Create /pmem0 and /pmem1 mount points and provide them with DAX file system:

All other bullets start with a small letter ...

Code quote:

Create

Copy link
Copy Markdown
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @lukaszstolarczuk)


scripts/README.md line 47 at r1 (raw file):

Foreach session with same users (or on system boot)

For each

Code quote:

Foreach

scripts/README.md line 63 at r1 (raw file):

Note: In case of a failure, you can investigate the reason for that by analyzing the content of the /home/hackathon/logs/ directory.

the reason of that ?

Code quote:

the reason for that

scripts/README.md line 73 at r1 (raw file):

users can be disabled selectively using docker stop.

the docker stop command.

Code quote:

docker stop

scripts/README.md line 107 at r1 (raw file):

  • docker/* please see the note within the docker/Dockerfile file

in ?

Code quote:

within 

Copy link
Copy Markdown
Contributor Author

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @ldorau)


docker/Dockerfile line 4 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

After having made changes ...

I believe it's ok, I've made a small update


scripts/README.md line 14 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

hackathon's

Done.


scripts/README.md line 28 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

All other bullets start with a small letter ...

Done.


scripts/README.md line 47 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

For each

Done.


scripts/README.md line 63 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

the reason of that ?

Done, re-written.


scripts/README.md line 73 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

the docker stop command.

Done.


scripts/README.md line 107 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

in ?

I guess both are correct, fixed anyway.

BTW, I moved it up, for clarity (I hope 😄 )

Copy link
Copy Markdown
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

Copy link
Copy Markdown
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@lukaszstolarczuk lukaszstolarczuk merged commit ee45f1b into pmemhackathon:main Sep 9, 2022
@lukaszstolarczuk lukaszstolarczuk deleted the scripts-README-fixes branch September 9, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants