common: docker/Dockerfile and scripts/README.md fixes and improvements#6
Conversation
ldorau
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @ldorau and @lukaszstolarczuk)
docker/Dockerfile line 4 at r1 (raw file):
# dockerfile for pmemhackathon, fc30 based # # Note: After making changes to files within this directory you have to rebuild
After having made changes ...
Code quote:
After making changesscripts/README.md line 14 at r1 (raw file):
Note: The command above copies part of the source tree to the hackathon home directory
hackathon's
Code quote:
hackathonscripts/README.md line 28 at r1 (raw file):
- Create
/pmem0and/pmem1mount points and provide them with DAX file system:
All other bullets start with a small letter ...
Code quote:
Create
ldorau
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @lukaszstolarczuk)
scripts/README.md line 47 at r1 (raw file):
Foreach session with same users (or on system boot)
For each
Code quote:
Foreachscripts/README.md line 63 at r1 (raw file):
Note: In case of a failure, you can investigate the reason for that by analyzing the content of the
/home/hackathon/logs/directory.
the reason of that ?
Code quote:
the reason for thatscripts/README.md line 73 at r1 (raw file):
users can be disabled selectively using docker stop.
the docker stop command.
Code quote:
docker stopscripts/README.md line 107 at r1 (raw file):
docker/*please see the note within thedocker/Dockerfilefile
in ?
Code quote:
within
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @ldorau)
docker/Dockerfile line 4 at r1 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
After having made changes ...
I believe it's ok, I've made a small update
scripts/README.md line 14 at r1 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
hackathon's
Done.
scripts/README.md line 28 at r1 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
All other bullets start with a small letter ...
Done.
scripts/README.md line 47 at r1 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
For each
Done.
scripts/README.md line 63 at r1 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
the reason of that?
Done, re-written.
scripts/README.md line 73 at r1 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
the
docker stopcommand.
Done.
scripts/README.md line 107 at r1 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
in?
I guess both are correct, fixed anyway.
BTW, I moved it up, for clarity (I hope 😄 )
3996732 to
8b9f22a
Compare
ldorau
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
ldorau
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
continuation of Janek's work (see original PR: pmemhackathon/2021-04-21.web#6)
This change is