Skip to content

docker: clean up the Dockerfile and speed up the build#7

Merged
igchor merged 2 commits intopmemhackathon:mainfrom
lukaszstolarczuk:update-dockerfile
Sep 9, 2022
Merged

docker: clean up the Dockerfile and speed up the build#7
igchor merged 2 commits intopmemhackathon:mainfrom
lukaszstolarczuk:update-dockerfile

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Sep 9, 2022

  • remove hardcoded memkind version in installation script - it should always use the most recent version (from master/main branch),
  • make use of all cores while compiling all libs,
  • remove redundant packages (mostly required for ndctl (?) ),
  • remove redundant steps and comments,
  • including removal of JNI, which is now built-in within Java binding.

// It's a continuation of my old work: pmemhackathon/2021-04-21.web#2


This change is Reviewable

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft September 9, 2022 15:24
- remove hardcoded memkind version in installation script - it should
  always use the most recent version (from master/main branch),
- make use of all cores while compiling all libs,
- remove redundant packages (mostly required for ndctl (?) ),
- remove redundant steps and comments,
- including removal of JNI, which is now built-in within Java binding.
it's especially useful for building docker images behind proxies;
Right now, it's the only parameter(s) handled in 'setup-maven-settings.sh'.
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review September 9, 2022 16:07
@igchor igchor merged commit 108345b into pmemhackathon:main Sep 9, 2022
@lukaszstolarczuk lukaszstolarczuk deleted the update-dockerfile branch September 12, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants