Improved tile spawning

There's no need to recreate the spawn packet for every single player, or re-serialize the NBT.

Author: dktapps

src/pocketmine/tile/Spawnable.php

@@ -31,19 +31,24 @@
 
 abstract class Spawnable extends Tile{
 
-	public function spawnTo(Player $player){
-		if($this->closed){
-			return false;
-		}
-
+	public function createSpawnPacket() : BlockEntityDataPacket{
 		$nbt = new NBT(NBT::LITTLE_ENDIAN);
 		$nbt->setData($this->getSpawnCompound());
 		$pk = new BlockEntityDataPacket();
 		$pk->x = $this->x;
 		$pk->y = $this->y;
 		$pk->z = $this->z;
 		$pk->namedtag = $nbt->write(true);
-		$player->dataPacket($pk);
+
+		return $pk;
+	}
+
+	public function spawnTo(Player $player){
+		if($this->closed){
+			return false;
+		}
+
+		$player->dataPacket($this->createSpawnPacket());
 
 		return true;
 	}
@@ -58,11 +63,8 @@ public function spawnToAll(){
 			return;
 		}
 
-		foreach($this->getLevel()->getChunkPlayers($this->chunk->getX(), $this->chunk->getZ()) as $player){
-			if($player->spawned === true){
-				$this->spawnTo($player);
-			}
-		}
+		$pk = $this->createSpawnPacket();
+		$this->level->addChunkPacket($this->chunk->getX(), $this->chunk->getZ(), $pk);
 	}
 
 	protected function onChanged(){