-
Notifications
You must be signed in to change notification settings - Fork 62
Code quality #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code quality #73
Conversation
- Fix some of the regex. - Prefer `for ([])` - Use some better array functions.
|
Thanks for the MR, the changes LGTM. Just a note, |
IIRC IE11 never supported the String.includes function. |
puckey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me – just one small question about the trailing comma added to tsconfig.json
|
Nice |
|
LGTM 👍 |
for ([]).includes