Skip to content

Conversation

@Gusted
Copy link
Contributor

@Gusted Gusted commented Jun 19, 2021

  • Fix some of the regex.
  • Prefer for ([])
  • Use some better array functions.
  • Don't be afraid of using .includes

Gusted added 3 commits June 19, 2021 13:38
- Fix some of the regex.
- Prefer `for ([])`
- Use some better array functions.
@TimvanScherpenzeel
Copy link
Collaborator

Thanks for the MR, the changes LGTM.

Just a note, .includes was problematic at some point for IE 11 so we should double check that the library still supports it after these changes.

@Gusted
Copy link
Contributor Author

Gusted commented Jun 19, 2021

Just a note, .includes was problematic at some point for IE 11 so we should double check that the library still supports it after these changes.

IIRC IE11 never supported the String.includes function.

Copy link
Collaborator

@puckey puckey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me – just one small question about the trailing comma added to tsconfig.json

@Aaronstcodes
Copy link

Nice

@TimvanScherpenzeel
Copy link
Collaborator

LGTM 👍

@TimvanScherpenzeel TimvanScherpenzeel merged commit ed89e69 into master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants