-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix test suite #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test suite #1361
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 15e8d3f:
|
|
I'm at a real stump right now, using https://github.com/nektos/act I can run the action locally but it still throws the error. I've raised an issue in Typescript since the Discord help channels did not yield any results – microsoft/TypeScript#43373 |
|
@creativiii, @CodyJasonBennett & @skylineproject I can merge this if you want (the tests do run locally and complete successfully) if that's helpful for you all? Or I can keep this in a branch till the CI issue is solved, let me know. |
bad link in setup.ts
|
Awesome @danielberndt, we even have coverage checks, in an ideal world I'd like them all to be 80+ so when people contribute and bump that up I'll be bumping the bar up too! |

Why
Fix the test suite.
resolves #1353 (hopefully)
What
Rejigged the
jest.config.js, I decided to use the great libraryts-jestinstead ofesbuild-jest. Which helped massively. also upgraded the version forjest,@testing-library/react,@testing-library/jest-dom.Also added
"esModuleInterop": true,to the tsconfig...Thoughts for later: use a
tsconfig.common.jsonto consolidate some settings.Checklist