Skip to content

Conversation

@joshuaellis
Copy link
Member

Why

Fix the test suite.
resolves #1353 (hopefully)

What

Rejigged the jest.config.js, I decided to use the great library ts-jest instead of esbuild-jest. Which helped massively. also upgraded the version for jest, @testing-library/react, @testing-library/jest-dom.

Also added "esModuleInterop": true, to the tsconfig...

Thoughts for later: use a tsconfig.common.json to consolidate some settings.

Checklist

  • Ready to be merged

@joshuaellis joshuaellis added kind: bug Something isn't working v9 labels Mar 24, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 24, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 15e8d3f:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration

@joshuaellis
Copy link
Member Author

I'm at a real stump right now, using https://github.com/nektos/act I can run the action locally but it still throws the error. I've raised an issue in Typescript since the Discord help channels did not yield any results – microsoft/TypeScript#43373

@joshuaellis
Copy link
Member Author

@creativiii, @CodyJasonBennett & @skylineproject I can merge this if you want (the tests do run locally and complete successfully) if that's helpful for you all? Or I can keep this in a branch till the CI issue is solved, let me know.

@joshuaellis joshuaellis merged commit 887511f into master Mar 25, 2021
@joshuaellis joshuaellis deleted the fix-test-suite branch March 25, 2021 16:40
@danielberndt
Copy link

Great! Can confirm that tests are now properly running for me 👍

image

@joshuaellis
Copy link
Member Author

Awesome @danielberndt, we even have coverage checks, in an ideal world I'd like them all to be 80+ so when people contribute and bump that up I'll be bumping the bar up too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v9: Tests won't finish

3 participants