Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] breaking: drop default exports #2238

Merged
merged 5 commits into from
Dec 10, 2023
Merged

Conversation

charkour
Copy link
Collaborator

@charkour charkour commented Dec 9, 2023

Summary

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Dec 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2023 11:33pm

Copy link

codesandbox-ci bot commented Dec 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17a5d79:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

src/context.ts Show resolved Hide resolved
@charkour charkour marked this pull request as ready for review December 9, 2023 15:32
@charkour charkour requested a review from dai-shi December 9, 2023 15:39
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, i thought the first one would be easy, but it doesn't seem so.
please see the comments. let me know if it's unclear.

src/shallow.ts Outdated Show resolved Hide resolved
src/context.ts Show resolved Hide resolved
rollup.config.js Show resolved Hide resolved
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's a good first step!

@dai-shi dai-shi merged commit 8030aee into pmndrs:v5 Dec 10, 2023
37 checks passed
@dai-shi dai-shi mentioned this pull request Dec 10, 2023
15 tasks
@charkour charkour deleted the v5-drop-defaults branch December 10, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants