Skip to content

Makeup input#2

Open
pmsgng wants to merge 7 commits intomainfrom
makeup-input
Open

Makeup input#2
pmsgng wants to merge 7 commits intomainfrom
makeup-input

Conversation

@pmsgng
Copy link
Copy Markdown
Owner

@pmsgng pmsgng commented Sep 26, 2021

@Muslik @smakhnatkin прошу проверить домашнее задание

</div>

<div class="input__tandem">
<div class="input__text">Дата и время заказа</div>
Copy link
Copy Markdown

@Muslik Muslik Sep 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Описание правильнее делать при помощи тега label

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пардон, я там указал тег label в скобочках и он его не отобразил )

<div class="input__tandem">
<div class="input__text">Дата и время заказа</div>
<div class="input__box input__box_incorrect">
<input type="text" value="06.12.2021" class="input__main">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Несмотря на введенное значение, у инпута должен быть placeholder

blocks/unput.css Outdated
@@ -0,0 +1,108 @@
body {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unput.css -> input.css

blocks/unput.css Outdated
padding: 0.5rem 0rem;
}
.input__text {
height: 1rem;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для чего тут высота?

blocks/unput.css Outdated
box-sizing: border-box;
border: 1px solid #459DF5;
}
.input__box_empty {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пустой стиль

<link href="https://fonts.googleapis.com/css2?family=Ubuntu:wght@300&display=swap" rel="stylesheet">
</head>
<body>
<div class="wrapper">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Классы названы не по БЭМ

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут видать ошибка. Два раза шапка вставлена

Copy link
Copy Markdown

@Muslik Muslik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправьте модификатор у input-а. Модификатор отвечает на вопрос какой? placeholder тут точно не подходит. И описание для текста должно быть сделано с помощью label, чтобы если я кликнул на описание, сразу установился фокус в инпут

<div class="input__group">
<div class="input__text">Дата и время заказа</div>
<div class="input__box input__box_incorrect">
<input type="text" placeholder="Введите" value="06.12.2021" class="input__main input__main_placeholder">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не бывает модификатора placeholder

<div class="input__box input__box_disabled">
<input type="text" value="06.12.2021" class="input__main">
<button class="input__button">
<div class="input__icon input__icon_locked"></div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут это просто иконка, а не кнопка насколько я понимаю. У disabled отображается иконка замочка

<link href="https://fonts.googleapis.com/css2?family=Ubuntu:wght@300&display=swap" rel="stylesheet">
</head>
<body>
<div class="wrapper">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут видать ошибка. Два раза шапка вставлена

Copy link
Copy Markdown
Collaborator

@baryshkov baryshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

хорошо сделано

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants