Skip to content

fix: log code hygiene failures#952

Open
realfishsam wants to merge 1 commit into
mainfrom
fix/easy-empty-catch-logging
Open

fix: log code hygiene failures#952
realfishsam wants to merge 1 commit into
mainfrom
fix/easy-empty-catch-logging

Conversation

@realfishsam
Copy link
Copy Markdown
Contributor

Summary

  • Add structured logging to silent TypeScript SDK/server-manager/sidecar catches
  • Narrow lock-file removal handling to ignore ENOENT only and log unexpected failures
  • Replace production console calls in the router E2E script with the core logger
  • Remove dead commented-out Polymarket debug console statements

Fixes #947
Fixes #946
Fixes #945
Fixes #944
Fixes #943
Fixes #942
Fixes #941
Fixes #940
Fixes #939
Fixes #938
Fixes #937
Fixes #808

Test Plan

  • git diff --check
  • npm run build --workspace=pmxt-core (timed out after 300s after tsc/copy output; no TypeScript errors emitted before timeout)
  • npm run build --workspace=pmxtjs (fails: generated TypeScript client missing at sdks/typescript/generated/src/index.js in this checkout)

@realfishsam
Copy link
Copy Markdown
Contributor Author

PR Review: PASS (NOT VERIFIED)

What This Does

Replaces empty catches and stray console output with structured logger calls so failure paths are observable without changing exchange response shapes.

Blast Radius

Core fetchers/auth/server utility scripts plus TypeScript SDK client/server-manager/ws-client logging paths.

Consumer Verification

Before (base branch):
Base silently swallowed Baozi/Myriad fetch fallback errors, lock-file remove failures, SDK server restart/probe failures, and contained commented/debug console statements.

After (PR branch):
PR logs those errors via PMXT loggers. Core build passed; core Jest tests passed (24 suites, 644 tests). Root verification then failed only because the local Python SDK test runner lacks pytest.

Test Results

  • Build: PASS
  • Unit tests: CORE PASS (24 suites, 644 tests; root verification blocked by missing pytest)
  • Server starts: PASS during root verification
  • E2E smoke: NOT VERIFIED (logging-only change; Python SDK phase unavailable)

Findings

No blocking findings.

PMXT Pipeline Check

  • Field propagation (3-layer): N/A
  • OpenAPI sync: N/A
  • Financial precision: N/A
  • Type safety: OK
  • Auth safety: OK — removed commented credential/debug logging rather than exposing secrets

Semver Impact

patch -- observability/code-hygiene fix.

Risk

Logging volume/levels were not exercised under real venue failures; no consumer API response-shape change is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment