Conversation
GitHub-hosted macOS runners don't support HVF (QEMU aborts with HV_UNSUPPORTED). DarwinBackend now auto-detects HVF via sysctl and falls back to TCG, matching LinuxBackend's KVM detection pattern. QEMU_ACCEL env var overrides detection for CI or debugging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
GitHub runners have /dev/kvm but it isn't accessible to the runner user. Use os.access() with R_OK|W_OK instead of Path.exists() so QEMU falls back to TCG instead of crashing with "Permission denied." Also respect QEMU_ACCEL env var like DarwinBackend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
actions/checkout@v4 and actions/upload-artifact@v4 use the deprecated Node.js 20 runtime. v5 uses Node.js 24. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Under TCG on CI, cloud-init status can take longer than 15s to respond while packages are installing. Catch TimeoutExpired and retry instead of crashing the test. Also bumped the per-poll timeout from 15s to 30s. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Poll for up to 3s instead of sleeping 1s to reliably catch fast failures like port-in-use. Print the actual mitmdump log output so the user sees the real error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
300s is too tight for macOS TCG on GitHub runners — cloud-init was still installing packages when the deadline expired. The job-level timeout (20min) is the real safety net. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.