Skip to content

Fixes asciinema player#7142

Merged
Jwaegebaert merged 2 commits intopnp:mainfrom
milanholemans:fix-asciinemaPlayer
Feb 25, 2026
Merged

Fixes asciinema player#7142
Jwaegebaert merged 2 commits intopnp:mainfrom
milanholemans:fix-asciinemaPlayer

Conversation

@milanholemans
Copy link
Contributor

  • Instead of relying on 3rd party services, we now host the cast files ourselves
  • Tried to upgrade cast files content to the latest version of CLI

Copilot AI review requested due to automatic review settings February 24, 2026 21:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes the documentation by replacing external asciinema.org links with self-hosted cast files, improving reliability and giving the project better control over demonstration content. The PR also updates most cast files to reflect the latest CLI version (v11.4.0).

Changes:

  • Added 6 asciinema cast files to the docs/static/casts directory
  • Updated AsciinemaPlayer component to use Docusaurus useBaseUrl hook for proper path resolution
  • Replaced all external asciinema.org URLs with local /casts/ paths across 5 documentation files

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/static/casts/usingCli.cast New cast file demonstrating CLI usage with status, spo app list, and cdn commands
docs/static/casts/logout.cast New cast file showing login, status, logout, and verification workflow
docs/static/casts/listCommands.cast New cast file demonstrating help commands for different command groups
docs/static/casts/install.cast New cast file showing CLI installation via npm
docs/static/casts/home.cast New cast file demonstrating basic CLI operations for homepage
docs/static/casts/commandHelp.cast New cast file showing command help functionality
docs/src/components/AsciinemaPlayer.tsx Updated to use useBaseUrl hook for proper path resolution in Docusaurus
docs/docs/user-guide/using-cli.mdx Updated AsciinemaPlayer references to use local cast files
docs/docs/user-guide/installing-cli.mdx Updated AsciinemaPlayer reference to use local cast file
docs/docs/user-guide/connecting-microsoft-365.mdx Updated AsciinemaPlayer reference to use local cast file
docs/docs/index.mdx Updated AsciinemaPlayer reference to use local cast file

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fourth time is the charm? LGTM! 😄

@Jwaegebaert Jwaegebaert merged commit fd81c8c into pnp:main Feb 25, 2026
10 checks passed
@milanholemans milanholemans deleted the fix-asciinemaPlayer branch February 25, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants