Updates 'spfx project github workflow add' sppkg path resolution#7232
Open
milanholemans wants to merge 1 commit intopnp:mainfrom
Open
Updates 'spfx project github workflow add' sppkg path resolution#7232milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans wants to merge 1 commit intopnp:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SPFx project github workflow add command to generate a GitHub Actions workflow using the .sppkg output path from config/package-solution.json, instead of assuming the package name matches the project name, and refreshes the workflow action dependencies.
Changes:
- Read
paths.zippedPackagefromconfig/package-solution.jsonand use it to populateAPP_FILE_PATHin the generated workflow. - Update the workflow template to newer action versions and replace
{{ solutionName }}with{{ sppkgPath }}. - Update unit test stubs to account for the additional
package-solution.jsonread.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/m365/spfx/commands/project/project-github-workflow-add.ts | Reads package-solution.json and substitutes {{ sppkgPath }} into the workflow’s APP_FILE_PATH. |
| src/m365/spfx/commands/project/project-github-workflow-add.spec.ts | Updates filesystem stubs to include config/package-solution.json. |
| src/m365/spfx/commands/project/DeployWorkflow.ts | Updates action versions and changes workflow template token to {{ sppkgPath }} for deploy package path. |
c4834e9 to
feecba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7233
Also updated the dependencies to the latest version.