Skip to content

Updates 'spfx project github workflow add' sppkg path resolution#7232

Open
milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans:update-workflow-deps
Open

Updates 'spfx project github workflow add' sppkg path resolution#7232
milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans:update-workflow-deps

Conversation

@milanholemans
Copy link
Copy Markdown
Contributor

@milanholemans milanholemans commented Apr 24, 2026

Closes #7233

Also updated the dependencies to the latest version.

Copilot AI review requested due to automatic review settings April 24, 2026 20:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SPFx project github workflow add command to generate a GitHub Actions workflow using the .sppkg output path from config/package-solution.json, instead of assuming the package name matches the project name, and refreshes the workflow action dependencies.

Changes:

  • Read paths.zippedPackage from config/package-solution.json and use it to populate APP_FILE_PATH in the generated workflow.
  • Update the workflow template to newer action versions and replace {{ solutionName }} with {{ sppkgPath }}.
  • Update unit test stubs to account for the additional package-solution.json read.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
src/m365/spfx/commands/project/project-github-workflow-add.ts Reads package-solution.json and substitutes {{ sppkgPath }} into the workflow’s APP_FILE_PATH.
src/m365/spfx/commands/project/project-github-workflow-add.spec.ts Updates filesystem stubs to include config/package-solution.json.
src/m365/spfx/commands/project/DeployWorkflow.ts Updates action versions and changes workflow template token to {{ sppkgPath }} for deploy package path.

Comment thread src/m365/spfx/commands/project/project-github-workflow-add.ts Outdated
Comment thread src/m365/spfx/commands/project/project-github-workflow-add.ts Outdated
Comment thread src/m365/spfx/commands/project/project-github-workflow-add.ts
Comment thread src/m365/spfx/commands/project/project-github-workflow-add.ts Outdated
Comment thread src/m365/spfx/commands/project/project-github-workflow-add.spec.ts
Comment thread src/m365/spfx/commands/project/project-github-workflow-add.spec.ts
@milanholemans milanholemans changed the title Updates 'spfx project github workflow add' dependencies Updates 'spfx project github workflow add' sppkg path resolution Apr 24, 2026


Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug report: spfx project github workflow add uses incorrect sppkg file path when package name is changed

2 participants