Skip to content

Added clearer feedback when using ACS to connect to a site that does not exist #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2023
Merged

Added clearer feedback when using ACS to connect to a site that does not exist #2707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0e8f9
Added error handling around using ACS to connect to a site URL that d…
KoenZomers Jan 7, 2023
11a7f93
Merge branch 'dev' into AcsConnectToNonExistantSiteError
gautamdsheth Jan 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Commands/Base/PnPConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,11 @@ internal static PnPConnection CreateWithACSAppOnly(Uri url, string realm, string
if (realm == null)
{
realm = GetRealmFromTargetUrl(url);

if(realm == null)
{
throw new Exception($"Could not determine realm for the target site '{url}'. Please validate that a site exists at this URL.");
}
}

if (url.DnsSafeHost.Contains("spoppe.com"))
Expand Down Expand Up @@ -772,7 +777,7 @@ internal static string GetRealmFromTargetUrl(Uri targetApplicationUri)
client.DefaultRequestHeaders.Authorization = new System.Net.Http.Headers.AuthenticationHeaderValue("Bearer", "");

var response = client.GetAsync(targetApplicationUri + "/_vti_bin/client.svc").GetAwaiter().GetResult();
if (response == null)
if (response == null || response.StatusCode == System.Net.HttpStatusCode.NotFound)
{
return null;
}
Expand Down