Skip to content

Conversation

@Studermarc
Copy link
Contributor

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Standard Channels cannot be created with the "ChannelType" Parameter

What is in this Pull Request ?

Changed the "OwnerUPN" to Mandatory = false for the "Specific" Parameter Set. Setting this Parameted to Mandadory is preventing Standard Channels to be created with the "ChannelType" Parameter, as it will always ask for an OwnerUPN, whereas none should be required to begin with.

Also correcting a small typo in the obsolete message for the "Private" switch.

Studermarc and others added 6 commits February 6, 2023 16:25
Changed the "OwnerUPN" to Mandatory = false for the "Specific" Parameter Set. Setting this Parameted to Mandadory is preventing Standard Channels to be created with the "ChannelType" Parameter, as it will always ask for an OwnerUPN, whereas none should be required to begin with.

Also correcting a small typo in the obsolete message for the "Private" switch
@KoenZomers
Copy link
Collaborator

Thanks for your contribution @Studermarc . The typical scenario was that when wanting to create a public/standard channel, one would just leave -ChannelType out, which would make it default to this type and not require an OwnerUPN to be specified. But indeed, this change makes sense so that if someone would provide it, it will still work. Merging your proposal with some small adjustments.

@KoenZomers KoenZomers merged commit ef0fd90 into pnp:dev Feb 15, 2023
@Studermarc
Copy link
Contributor Author

Awsome, many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants