Enhance Azure AD Workload Identity support by validating environment variables and improving error handling for token file access#5286
Merged
Merged
Conversation
…variables and improving error handling for token file access
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Connect-PnPOnline -AzureADWorkloadIdentity failures in non-Azure workload identity environments (e.g., GitHub Actions) by validating required environment variables up-front and improving token file error handling, plus clarifying documentation to guide users to the correct auth switch.
Changes:
- Validate required
AZURE_*environment variables for Azure AD Workload Identity and throw clearerPSInvalidOperationExceptionmessages when missing. - Add explicit token file existence check and wrap token file read errors with a more actionable message.
- Update
Connect-PnPOnlinedocs to clarify when to use-AzureADWorkloadIdentityvs-FederatedIdentity.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Commands/Base/TokenHandler.cs | Adds env var validation and improved token file access error handling for Azure AD Workload Identity token acquisition. |
| documentation/Connect-PnPOnline.md | Clarifies recommended switch usage and required environment variables for workload identity vs federated identity scenarios. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #5277
What is in this Pull Request ?
Improved some error handling