Refactor HTTP request handling for improved resource management and error handling#5296
Merged
gautamdsheth merged 4 commits intodevfrom Apr 22, 2026
Merged
Refactor HTTP request handling for improved resource management and error handling#5296gautamdsheth merged 4 commits intodevfrom
gautamdsheth merged 4 commits intodevfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors several HTTP/process handling call sites to improve resource management (disposing requests/responses/processes) and centralize request construction/serialization behavior across the module.
Changes:
- Refactors version checking HTTP calls to use a shared helper with cancellation-based timeout and proper disposal.
- Refactors REST helper methods to build per-request
HttpRequestMessageobjects (instead of mutatingHttpClient.DefaultRequestHeaders) and reuses sharedJsonSerializerOptions. - Ensures
HttpResponseMessage/Processobjects are disposed in multiple call sites (Graph invoke methods, unified audit log paging, shell runner).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Commands/Utilities/VersionChecker.cs | Introduces a helper to fetch version check content with cancellation timeout + disposals. |
| src/Commands/Utilities/Shell.cs | Disposes the created Process via using var. |
| src/Commands/Utilities/REST/RestHelper.cs | Moves header/auth to per-request messages; reuses serializer options; adds helper to apply additional headers. |
| src/Commands/Utilities/CmdletMessageWriter.cs | Makes queue access thread-safe via locking and simplifies dequeue logic. |
| src/Commands/ManagementApi/GetUnifiedAuditLog.cs | Fixes URL interpolation and disposes paged HTTP responses reliably. |
| src/Commands/Graph/InvokeGraphMethod.cs | Disposes responses for POST/PUT/PATCH/DELETE helpers via using var. |
Co-authored-by: Copilot <copilot@github.com>
…tively Co-authored-by: Copilot <copilot@github.com>
… improved clarity and consistency Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md
Type
Related Issues?
Fixes #X, partially fixes #Y, mentioned in #Z, etc.
What is in this Pull Request ?
Please describe the changes in the PR.
Guidance