feat: Logging installed pnpm version#245
Conversation
📝 WalkthroughWalkthroughBootstrap package.json creation now uses object constants for the embedded pnpm / ChangesBootstrap Package JSON Refactor & Version Logging
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/install-pnpm/run.ts`:
- Around line 29-30: The code computes installedVersion up front (const
installedVersion = standalone ? BOOTSTRAP_EXE_PACKAGE.dependencies['@pnpm/exe']
: BOOTSTRAP_PNPM_PACKAGE.dependencies.pnpm) but later may perform a self-update
to targetVersion and still logs the original installedVersion; update the logic
so the logged version is determined after any self-update: either set a new
variable (e.g., loggedVersion) to targetVersion when the self-update path (the
code that uses targetVersion) runs, or recompute/read the actual installed
package version from the written package.json/installed metadata before logging;
adjust uses in run.ts to reference this post-update value instead of the
original installedVersion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c34c81ae-ba17-47fe-b9aa-00426ad1e855
⛔ Files ignored due to path filters (1)
dist/index.jsis excluded by!**/dist/**
📒 Files selected for processing (1)
src/install-pnpm/run.ts
This resolves #238
Summary by CodeRabbit