feat: `pnpm logout` by KSXGitHub · Pull Request #11213 · pnpm/pnpm

KSXGitHub · 2026-04-06T07:59:38Z

This PR implements the pnpm logout command, allowing users to log out of npm registries by revoking their authentication tokens both on the registry and locally.

https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

auth/commands/test/logout.test.ts

Copilot

Pull request overview

This PR adds first-class support for pnpm logout, wiring it into the CLI and implementing the underlying auth token revocation + local credential cleanup logic in @pnpm/auth.commands.

Changes:

Register a new logout command in the pnpm CLI (and remove it from the “not implemented” list).
Implement logout command logic in @pnpm/auth.commands, including registry token revocation and auth.ini cleanup.
Add unit tests and a changeset for the new command.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pnpm/src/cmd/notImplemented.ts	Removes `logout` from the not-implemented command set.
pnpm/src/cmd/index.ts	Adds `logout` to the CLI command registry.
auth/commands/src/logout.ts	Implements `pnpm logout` command behavior (revoke + local config updates).
auth/commands/src/login.ts	Tightens `LoginFetchOptions.method` type.
auth/commands/src/index.ts	Exports the new `logout` command module.
auth/commands/test/logout.test.ts	Adds unit test coverage for logout scenarios.
.changeset/implement-pnpm-logout.md	Declares minor releases for `pnpm` and `@pnpm/auth.commands`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

auth/commands/src/logout.ts

auth/commands/test/logout.test.ts

auth/commands/src/logout.ts

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

auth/commands/src/logout.ts

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Adds a new `pnpm logout` command that logs users out of npm registries. The command revokes the authentication token on the registry via DELETE /-/user/token/{token}, then removes it from the local auth.ini config file. Token revocation is best-effort: local cleanup always proceeds even if the registry is unreachable or doesn't support revocation. Uses the same dependency injection pattern as `pnpm login` for comprehensive testability. https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

- Rename revokeToken to tryRevokeToken for self-documenting code - Extract token removal into removeTokenFromAuthIni function - Remove redundant comments that restate function names - Fix toHaveProperty to use array syntax for keys containing dots (avoids Jest property path parsing pitfall) - Add globalWarn when token is found in authConfig but not in auth.ini, informing the user it must be removed manually from .npmrc - Add tests for the .npmrc-only warning case https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

Use path.join in test expectations for the warning message path, since path.join produces backslashes on Windows. https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

Replace manual fetchedUrls arrays with jest.fn() mocks and use toHaveBeenCalledWith for cleaner, more idiomatic assertions. https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

- Rename mockFetch to fetch for shorthand property syntax - Use platform-aware configDir in warning tests instead of path.join on Unix-style paths https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

Single-statement return-with-braces arrow function converted to expression-body form. https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

- Send Authorization: Bearer header in the DELETE token revocation request, otherwise the registry returns 401 and the token is not actually revoked - Make tryRevokeToken return a boolean indicating whether the token was actually revoked, and use it to choose the right warning when the token is not in auth.ini - Drop the misleading "(token removed locally)" suffix from the registry-failure log messages, since the local removal may not happen - Extract getRegistryConfigKey and safeReadIniFile from login.ts and logout.ts into a shared module to prevent the two commands from drifting apart over time - Add tests asserting the Authorization header is sent and that the warning correctly distinguishes between revoked and not-revoked cases https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

When the registry rejects the token revocation AND the token is not in auth.ini, neither side effect of logout actually happened — the user is still authenticated locally and on the registry. Throwing an ERR_PNPM_LOGOUT_FAILED error in this case avoids the misleading "Logged out of ..." success message and gives a non-zero exit code. https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

KSXGitHub changed the title ~~Implement pnpm logout command for registry authentication~~ feat: pnpm logout Apr 6, 2026

This comment was marked as resolved.

Sign in to view

KSXGitHub commented Apr 6, 2026

View reviewed changes

auth/commands/test/logout.test.ts Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

KSXGitHub commented Apr 7, 2026

View reviewed changes

auth/commands/test/logout.test.ts Outdated Show resolved Hide resolved

KSXGitHub marked this pull request as ready for review April 7, 2026 06:59

KSXGitHub requested a review from zkochan as a code owner April 7, 2026 06:59

Copilot AI review requested due to automatic review settings April 7, 2026 06:59

Copilot started reviewing on behalf of KSXGitHub April 7, 2026 07:00 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

KSXGitHub marked this pull request as draft April 7, 2026 07:06

KSXGitHub marked this pull request as ready for review April 7, 2026 07:14

KSXGitHub requested a review from Copilot April 7, 2026 07:15

Copilot started reviewing on behalf of KSXGitHub April 7, 2026 07:16 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

auth/commands/src/logout.ts Show resolved Hide resolved

KSXGitHub marked this pull request as draft April 7, 2026 07:25

KSXGitHub marked this pull request as ready for review April 7, 2026 07:27

KSXGitHub requested a review from Copilot April 7, 2026 07:28

Copilot started reviewing on behalf of KSXGitHub April 7, 2026 07:29 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

claude and others added 10 commits April 7, 2026 10:29

fix(auth): fix Windows CI failure in logout test

b2282b5

Use path.join in test expectations for the warning message path, since path.join produces backslashes on Windows. https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

refactor(auth): use jest.fn() for fetch assertions in logout tests

99ad2b4

Replace manual fetchedUrls arrays with jest.fn() mocks and use toHaveBeenCalledWith for cleaner, more idiomatic assertions. https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

refactor: destructure context

fa63d9f

refactor: literal types for method

4f1d53f

refactor(auth): test cleanup per review feedback

ba1cecb

- Rename mockFetch to fetch for shorthand property syntax - Use platform-aware configDir in warning tests instead of path.join on Unix-style paths https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

style(auth): remove redundant return in createMockResponse arrow

dfa2387

Single-statement return-with-braces arrow function converted to expression-body form. https://claude.ai/code/session_016fw5sdGFtBiB9QapMKEuXa

zkochan force-pushed the claude/implement-pnpm-logout-3Rvdf branch from 5b89d28 to 2fd86ee Compare April 7, 2026 08:29

zkochan approved these changes Apr 7, 2026

View reviewed changes

zkochan merged commit 16cfde6 into main Apr 7, 2026
12 checks passed

zkochan deleted the claude/implement-pnpm-logout-3Rvdf branch April 7, 2026 09:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: `pnpm logout`#11213

feat: `pnpm logout`#11213
zkochan merged 10 commits intomainfrom
claude/implement-pnpm-logout-3Rvdf

KSXGitHub commented Apr 6, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

KSXGitHub commented Apr 6, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants