fix: provide correct run url #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocesar
pushed a commit
that referenced
this pull request
Mar 3, 2025
* chore: update actor folder * feat: add `slackPrefix` to input (#1) * fix: add jasmine namespace to the context * fix: wait 5 sec at the end of run instead of 18 sec before loading data * change: upgrade to node 18 * feat: pass in Apify and apifyClient into the spec * added prefilledInput field to run * fixed no await * converted to esm and added arktype * changed fetch for client * added maxResults (or resultsLimit) to return * linted and added default maxResults * prefill hotfix (#3) * perf & feat: remove sleep after run, add runInput to runResult * fix: overriden info.itemCount with actual dataset items.length * fix: typo forgotten 'run' variable * fix(partial): prefilledInput fallsback to 'latest' if build numver is used * feat: resolve build automatically from input.customData.build * feat: handle input.customData.build directly in this actor * fix: load only clean items * fix: we should get the actual input resultsLimit if it exists too (#4) * fix: use taskId from test spec run to determine actorId to use correct build * decrazy the code a bit (#6) * cleanup formatRunMessage logic * decrazy the code a bit * add run link to all failed expectations (#7) * fix: try-catch setSpecProperty in run() * fix: correctly use non-default build for prefilled input if passed in * docs: remove forgotten logs * chore: bump `apify-client` and `apify` (#8) * fix: update result of run call with run info after run finishes * feat: withRunInfo --------- Co-authored-by: metalwarrior665 <lukaskrivka@gmail.com> Co-authored-by: Sviatozar Petrenko <svpetrenko123@gmail.com> Co-authored-by: JameEnder <jameender@email.cz> Co-authored-by: Jakub <47925045+JameEnder@users.noreply.github.com> Co-authored-by: Matěj Volf <mat.volfik@gmail.com> Co-authored-by: Matěj Volf <matej.volf@apify.com> Co-authored-by: oklinov <oklinov@tutanota.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.