Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions execute_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ cd ..
echo "Running TiledCartPole environment tests"
cd test_tiled_cart_pole/ && ./test_tiled_cart_pole
cd ..
echo "Running GridWorld environment tests"
cd test_grid_world/ && ./test_grid_world
cd ..
22 changes: 0 additions & 22 deletions src/gymfcpp/cart_pole_env.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -178,28 +178,6 @@ CartPole::make(){
is_created = true;
}

/*CartPole::time_step_type
CartPole::reset(){

#ifdef GYMFCPP_DEBUG
assert(is_created && "Environment has not been created");
#endif

auto cpp_str = std::string(CartPole::py_reset_result_name + " = ");
cpp_str += CartPole::py_env_name + ".reset().tolist()";

// reset the python environment
boost::python::exec(cpp_str.c_str(), gym_namespace);

// the observation
auto observation = boost::python::extract<boost::python::list>(gym_namespace[CartPole::py_reset_result_name]);
auto obs = extract_obs(observation);

current_state = time_step_type(TimeStepTp::FIRST, 0.0, obs);
return current_state;

}*/


CartPole::time_step_type
CartPole::step(const action_type action){
Expand Down
2 changes: 1 addition & 1 deletion src/gymfcpp/frozen_lake_env.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ discrete_state_space_frozen_lake<8>::sample(){
}

template<uint_t side_size>
std::string FrozenLakeData<side_size>::name = "FrozenLake";
const std::string FrozenLakeData<side_size>::name = "FrozenLake";


template<uint_t side_size>
Expand Down
2 changes: 1 addition & 1 deletion src/gymfcpp/frozen_lake_env.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ struct FrozenLakeData
///
/// \brief name
///
static std::string name;
static const std::string name;

///
/// \brief time_step_t. The type of the time step
Expand Down
Loading