Skip to content

creating component form of election#57

Merged
frattezi merged 7 commits intomainfrom
form-election/joel
Sep 12, 2024
Merged

creating component form of election#57
frattezi merged 7 commits intomainfrom
form-election/joel

Conversation

@Joel-leal
Copy link
Copy Markdown
Contributor

@Joel-leal Joel-leal commented Mar 19, 2024

Description

(brief description of the changes made and include screenshots as needed) @Joel-leal you can start a simple description here

Changes

(list of the changes been made) @Joel-leal lets start adding what is already done here, I'm leaving this to you

  • item 1
  • item 2

TODO

  • Move create election to Modal
  • Finish election model, complete form with missing attributes if there are any
  • @Joel-leal feel free to add any other tasks here if you feel like it, I will work today on creating some tasks in our board so we can have a proper process, thank you! 🙇🏼

Closes #58

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
voting-system ⬜️ Ignored (Inspect) Aug 12, 2024 6:09pm

Copy link
Copy Markdown
Contributor

@frattezi frattezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Joel! 👋🏼

Added a few comments, let's try to solve this tomorrow and then move forward with the other TODOs!

PS: I'm adding a TODO list in this PR description, with everything we need to consider it done!

Comment thread src/packages/components/HomePage/CreateElection.tsx Outdated
Comment thread src/packages/components/HomePage/CreateElection.tsx
Comment thread src/packages/components/HomePage/CreateElection.tsx
Comment thread src/packages/DAO/elections.dao.ts Outdated
Comment thread src/packages/DAO/elections.dao.ts
Comment thread src/packages/DAO/elections.dao.ts Outdated
Comment thread src/packages/DAO/elections.dao.ts Outdated
Comment thread src/packages/DAO/elections.dao.ts Outdated
Comment thread src/packages/components/HomePage/CreateElection.tsx Outdated
Comment thread src/packages/components/HomePage/CreateElection.tsx
@frattezi
Copy link
Copy Markdown
Contributor

Refactor component now using shadcn.

Comment thread prisma/schema.prisma
Comment thread package-lock.json
Copy link
Copy Markdown
Contributor

@frattezi frattezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Joel-leal great work! Just added a few comments

Comment thread src/packages/components/HomePage/ModalCreateElection.tsx Outdated
Comment thread src/packages/components/HomePage/ModalCreateElection.tsx Outdated
Comment thread src/packages/components/HomePage/ModalCreateElection.tsx Outdated
Comment thread src/packages/components/HomePage/CreateElection.tsx
Copy link
Copy Markdown
Contributor

@frattezi frattezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's keep rolling! 🪨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add create election form to App's main page

2 participants