Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Joel-leal
force-pushed
the
link-route-election/joel
branch
from
b696123 to
e7f9f45
Compare
frattezi
reviewed
Sep 17, 2024
frattezi
reviewed
Sep 17, 2024
Contributor
frattezi
left a comment
frattezi
left a comment
There was a problem hiding this comment.
Just some minors, but looks good!
Contributor
|
Remove the route.ts file under |
frattezi
approved these changes
Oct 17, 2024
Contributor
frattezi
left a comment
frattezi
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment
| }); | ||
|
|
||
| revalidatePath("/"); | ||
| redirect(`http://localhost:3000/elections/${electionId}`); |
Contributor
There was a problem hiding this comment.
We need to setup this as a environment var called APP_BASE_URL as this will change depending on environment.
With the redirect command, in this case here, you can also omit the base url and send only the paths ahead, like:
Suggested change
| redirect(`http://localhost:3000/elections/${electionId}`); | |
| redirect(`elections/${electionId}`); |
Contributor
There was a problem hiding this comment.
No need for adding the env var as I mentioned if you follow this alternative
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a new route to handle redirection based on an election ID. This route captures the ID from the URL to fetch election details from the database.
Changes
Notes
Board issue